From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <amwang@redhat.com>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org,
Andy Gospodarek <gospo@redhat.com>,
Neil Horman <nhorman@tuxdriver.com>,
Jeff Moyer <jmoyer@redhat.com>, Matt Mackall <mpm@selenic.com>,
bonding-devel@lists.sourceforge.net,
Jay Vosburgh <fubar@us.ibm.com>,
David Miller <davem@davemloft.net>
Subject: Re: [v3 Patch 2/3] bridge: make bridge support netpoll
Date: Mon, 12 Apr 2010 12:38:57 +0200 [thread overview]
Message-ID: <1271068737.16881.18.camel@edumazet-laptop> (raw)
In-Reply-To: <4BC2F7E2.7020309@redhat.com>
Le lundi 12 avril 2010 à 18:37 +0800, Cong Wang a écrit :
> Stephen Hemminger wrote:
> > There is no protection on dev->priv_flags for SMP access.
> > It would better bit value in dev->state if you are using it as control flag.
> >
> > Then you could use
> > if (unlikely(test_and_clear_bit(__IN_NETPOLL, &skb->dev->state)))
> > netpoll_send_skb(...)
> >
> >
>
> Hmm, I think we can't use ->state here, it is not for this kind of purpose,
> according to its comments.
>
> Also, I find other usages of IFF_XXX flags of ->priv_flags are also using
> &, | to set or clear the flags. So there must be some other things preventing
> the race...
Yes, its RTNL that protects priv_flags changes, hopefully...
next prev parent reply other threads:[~2010-04-12 10:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 6:18 [v3 Patch 1/3] netpoll: add generic support for bridge and bonding devices Amerigo Wang
2010-04-08 6:18 ` [v3 Patch 2/3] bridge: make bridge support netpoll Amerigo Wang
2010-04-08 15:37 ` Stephen Hemminger
2010-04-09 5:43 ` Cong Wang
2010-04-12 10:37 ` Cong Wang
2010-04-12 10:38 ` Eric Dumazet [this message]
2010-04-12 15:38 ` [Bonding-devel] " Stephen Hemminger
2010-04-13 8:57 ` Cong Wang
2010-04-13 16:52 ` Jay Vosburgh
2010-04-13 17:33 ` Stephen Hemminger
2010-04-14 8:16 ` Cong Wang
2010-04-14 8:11 ` Cong Wang
2010-04-08 6:19 ` [v3 Patch 3/3] bonding: make bonding " Amerigo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271068737.16881.18.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=amwang@redhat.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=gospo@redhat.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox