From: Eric Dumazet <eric.dumazet@gmail.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH v3] net: batch skb dequeueing from softnet input_pkt_queue
Date: Wed, 14 Apr 2010 17:20:09 +0200 [thread overview]
Message-ID: <1271258409.16881.1701.camel@edumazet-laptop> (raw)
In-Reply-To: <1271238738-8386-1-git-send-email-xiaosuo@gmail.com>
Le mercredi 14 avril 2010 à 17:52 +0800, Changli Gao a écrit :
> batch skb dequeueing from softnet input_pkt_queue
>
> batch skb dequeueing from softnet input_pkt_queue to reduce potential lock
> contention and irq disabling/enabling.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Adding stop_machine() with no explanation ?
No ack from my previous comments, suggestions, and still same logic ?
Are we supposed to read patch, test it, make some benches, correct bugs,
say Amen ?
This is becoming silly, if you ask me.
This is a NACK of this patch, obviously.
next prev parent reply other threads:[~2010-04-14 15:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 9:52 [PATCH v3] net: batch skb dequeueing from softnet input_pkt_queue Changli Gao
2010-04-14 11:58 ` jamal
2010-04-14 12:13 ` Changli Gao
2010-04-14 12:28 ` jamal
2010-04-14 15:20 ` Eric Dumazet [this message]
2010-04-14 23:13 ` Changli Gao
2010-04-21 23:05 ` Eric Dumazet
2010-04-21 23:23 ` Tom Herbert
2010-04-22 1:35 ` Changli Gao
2010-04-22 6:33 ` Changli Gao
2010-04-22 7:13 ` Eric Dumazet
2010-04-22 7:17 ` David Miller
2010-04-22 12:13 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271258409.16881.1701.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox