From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: krkumar2@in.ibm.com, netdev@vger.kernel.org, nuclearcat@nuclearcat.com
Subject: Re: NULL pointer dereference panic in stable (2.6.33.2), amd64
Date: Thu, 15 Apr 2010 22:46:15 +0200 [thread overview]
Message-ID: <1271364375.16881.3099.camel@edumazet-laptop> (raw)
In-Reply-To: <1271363432.16881.3080.camel@edumazet-laptop>
Le jeudi 15 avril 2010 à 22:30 +0200, Eric Dumazet a écrit :
>
> @@ -1938,6 +1928,8 @@ gso:
> if (dev->priv_flags & IFF_XMIT_DST_RELEASE)
> skb_dst_drop(nskb);
>
> + skb_orphan(nskb);
> +
> rc = ops->ndo_start_xmit(nskb, dev);
> if (unlikely(rc != NETDEV_TX_OK)) {
> if (rc & ~NETDEV_TX_MASK)
Well, might need to test if skb is not shared before orphaning it
if (!skb_shared(skb))
skb_orphan(nskb);
next prev parent reply other threads:[~2010-04-15 20:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-11 20:38 NULL pointer dereference panic in stable (2.6.33.2), amd64 Denys Fedorysychenko
2010-04-11 22:35 ` Eric Dumazet
2010-04-11 23:04 ` Denys Fedorysychenko
2010-04-11 23:11 ` Eric Dumazet
2010-04-11 23:36 ` Denys Fedorysychenko
2010-04-12 3:38 ` Krishna Kumar2
2010-04-12 6:01 ` Eric Dumazet
2010-04-12 7:18 ` Eric Dumazet
2010-04-12 7:36 ` David Miller
2010-04-15 6:52 ` David Miller
2010-04-15 8:02 ` Eric Dumazet
2010-04-15 8:26 ` David Miller
2010-04-15 8:51 ` Eric Dumazet
2010-04-15 9:06 ` David Miller
2010-04-15 9:11 ` Denys Fedorysychenko
2010-04-15 10:37 ` Eric Dumazet
2010-04-29 10:50 ` Denys Fedorysychenko
2010-04-15 20:30 ` Eric Dumazet
2010-04-15 20:46 ` Eric Dumazet [this message]
2010-04-15 21:33 ` David Miller
2010-04-16 22:18 ` [PATCH net-next-2.6] net: Introduce skb_orphan_try() Eric Dumazet
2010-04-18 9:46 ` David Miller
2010-04-21 6:08 ` Eric Dumazet
2010-04-22 5:56 ` David Miller
2010-04-22 7:10 ` Eric Dumazet
2010-04-22 7:16 ` David Miller
2010-04-22 7:24 ` Eric Dumazet
2010-04-22 7:26 ` David Miller
2010-04-22 7:33 ` Eric Dumazet
2010-04-22 7:41 ` David Miller
2010-04-22 7:47 ` Eric Dumazet
2010-04-22 7:54 ` David Miller
2010-04-22 7:59 ` Eric Dumazet
2010-04-12 7:54 ` NULL pointer dereference panic in stable (2.6.33.2), amd64 Krishna Kumar2
2010-04-12 9:31 ` Eric Dumazet
2010-04-12 16:11 ` Denys Fedorysychenko
2010-04-12 20:09 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271364375.16881.3099.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nuclearcat@nuclearcat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox