From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: another cleanup patch gone wrong Date: Thu, 15 Apr 2010 20:11:46 -0700 Message-ID: <1271387506.2298.17.camel@Joe-Laptop.home> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Paul Gortmaker , netdev@vger.kernel.org, Linux Kernel Mailing List , Linux/m68k To: Finn Thain Return-path: In-Reply-To: Sender: linux-m68k-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, 2010-04-16 at 12:34 +1000, Finn Thain wrote: > ...but this one was already merged, unfortunately. > > > Use printk_once > > Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Convert printks without KERN_ to pr_info and pr_cont > > > > Signed-off-by: Joe Perches > > Signed-off-by: David S. Miller > > > > > > diff --git a/drivers/net/mac8390.c b/drivers/net/mac8390.c > > index 517cee4..8bd09e2 100644 (file) > > --- a/drivers/net/mac8390.c > > +++ b/drivers/net/mac8390.c > > @@ -17,6 +17,8 @@ > > /* 2002-12-30: Try to support more cards, some clues from NetBSD driver */ > > /* 2003-12-26: Make sure Asante cards always work. */ > > > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > + > > Why the macro? You only used it once. It's used embedded in the pr_ functions. It's used more than once. > The pr_xxx naming convention belongs to a kernel-wide include file. Is it > really a good idea to start repurposing it in .c files? It's in kernel.h, and yes, it is. http://lkml.org/lkml/2008/11/12/297 > No, this is pr_err. The driver sets dev->mem_start expecting it to work, > obviously. I suggest you change the levels to what you desire. You could add yourself to the MAINTAINERS entry for this file. cheers, Joe