From: jamal <hadi@cyberus.ca>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Changli Gao <xiaosuo@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Tom Herbert <therbert@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v5] net: batch skb dequeueing from softnet input_pkt_queue
Date: Thu, 22 Apr 2010 08:17:33 -0400 [thread overview]
Message-ID: <1271938653.4032.33.camel@bigi> (raw)
In-Reply-To: <1271936227.7895.5285.camel@edumazet-laptop>
On Thu, 2010-04-22 at 13:37 +0200, Eric Dumazet wrote:
> Please reorder things better.
>
> Most likely this function is called for one packet.
>
> In your version you take twice the rps_lock()/rps_unlock() path, so
> it'll be slower.
>
> Once to 'transfert' one list to process list
>
> Once to be able to do the 'label out:' post processing.
>
Ok, once it is settled the right changes are i will test.
cheers,
jamal
next prev parent reply other threads:[~2010-04-22 12:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 9:09 [PATCH v5] net: batch skb dequeueing from softnet input_pkt_queue Changli Gao
2010-04-22 9:43 ` David Miller
2010-04-22 12:27 ` Changli Gao
2010-04-22 14:24 ` Eric Dumazet
2010-04-22 11:37 ` Eric Dumazet
2010-04-22 12:17 ` jamal [this message]
2010-04-22 13:06 ` Changli Gao
2010-04-22 14:33 ` Eric Dumazet
2010-04-22 14:54 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271938653.4032.33.camel@bigi \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).