From: Elina Pasheva <epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public.gmane.org>
To: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
Cc: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
"davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org"
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Rory Filer
<rfiler-usJ8hg9QsBLWpu6QEFMNjNBPR1lH4CV8@public.gmane.org>,
"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Subject: re-submit4 [ANNOUNCEMENT] NET: usb: sierra_net.c driver
Date: Thu, 22 Apr 2010 16:16:48 -0700 [thread overview]
Message-ID: <1271978208.12776.7.camel@Linuxdev4-laptop> (raw)
In-Reply-To: <20100422222723.GB3187-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
On Thu, 2010-04-22 at 15:27 -0700, Greg KH wrote:
> > > > +
> > > > + status = usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0),
> > > > + USB_CDC_SEND_ENCAPSULATED_COMMAND,
> > > > + USB_DIR_OUT|USB_TYPE_CLASS|USB_RECIP_INTERFACE, 0,
> > > > + priv->ifnum, cmd, cmdlen, 0);
> > >
> > > No timeout?
Good catch. Will fix.
> > > No timeout?
Will fix.
> > >
> > > > + if (unlikely(len < 0)) {
> > > > + netdev_err(dev->net,
> > > > + "usb_control_msg failed, status %d\n", len);
> > >
> > > You don't need "unlikely", this is an extreemly slow path here.
Will fix.
> Well, if the return value is less than what you expect it to be,
> something went wrong and you should error out. Some of the calls handle
> this properly in this driver, some do not. Consistency is key :)
Good point. Thanks. Will check for consistency and resubmit.
Elina
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-04-22 23:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 19:19 Subject: re-submit4 [ANNOUNCEMENT] NET: usb: sierra_net.c driver Elina Pasheva
2010-04-22 19:44 ` Greg KH
2010-04-22 21:15 ` Dan Williams
2010-04-22 22:27 ` Greg KH
[not found] ` <20100422222723.GB3187-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2010-04-22 23:16 ` Elina Pasheva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271978208.12776.7.camel@Linuxdev4-laptop \
--to=epasheva-ywe8ttl5ejhwpu6qefmnjnbpr1lh4cv8@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rfiler-usJ8hg9QsBLWpu6QEFMNjNBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).