From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: [PATCH net-2.6 2/9] sfc: Ignore parity errors in the other port's SRAM
Date: Fri, 23 Apr 2010 23:24:19 +0100 [thread overview]
Message-ID: <1272061459.5520.15.camel@achroite.uk.solarflarecom.com> (raw)
In-Reply-To: <0998e2e60655106abde76dcb4b7bac1136d1a11f.1272061382.git.bhutchings@solarflare.com>
From: Steve Hodgson <shodgson@solarflare.com>
Siena has a separate SRAM bank for each port. On single-port boards
these can be merged together, so each port has an interrupt flag for
parity errors in the other port's SRAM. Currently we do not enable
such merging and should mask this interrupt source.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
drivers/net/sfc/nic.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/sfc/nic.c b/drivers/net/sfc/nic.c
index b06f8e3..664fd6c 100644
--- a/drivers/net/sfc/nic.c
+++ b/drivers/net/sfc/nic.c
@@ -1563,6 +1563,8 @@ void efx_nic_init_common(struct efx_nic *efx)
FRF_AZ_ILL_ADR_INT_KER_EN, 1,
FRF_AZ_RBUF_OWN_INT_KER_EN, 1,
FRF_AZ_TBUF_OWN_INT_KER_EN, 1);
+ if (efx_nic_rev(efx) >= EFX_REV_SIENA_A0)
+ EFX_SET_OWORD_FIELD(temp, FRF_CZ_SRAM_PERR_INT_P_KER_EN, 1);
EFX_INVERT_OWORD(temp);
efx_writeo(efx, &temp, FR_AZ_FATAL_INTR_KER);
--
1.6.2.5
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next parent reply other threads:[~2010-04-23 22:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0998e2e60655106abde76dcb4b7bac1136d1a11f.1272061382.git.bhutchings@solarflare.com>
2010-04-23 22:24 ` Ben Hutchings [this message]
2010-04-23 22:25 ` [PATCH net-2.6 3/9] sfc: Always close net device at the end of a disabling reset Ben Hutchings
2010-04-23 22:25 ` [PATCH net-2.6 4/9] sfc: Consistently report short MCDI responses as EIO Ben Hutchings
2010-04-23 22:26 ` [PATCH net-2.6 5/9] sfc: Change falcon_probe_board() to fail for unsupported boards Ben Hutchings
2010-04-23 22:27 ` [PATCH net-2.6 6/9] sfc: Handle serious errors in exactly one interrupt handler Ben Hutchings
2010-04-23 22:27 ` [PATCH net-2.6 7/9] sfc: Stop masking out XGMII faults over reconfigures Ben Hutchings
2010-04-23 22:28 ` [PATCH net-2.6 8/9] sfc: Reconfigure the XAUI serdes after an EM reset Ben Hutchings
2010-04-23 22:28 ` [PATCH net-2.6 9/9] sfc: Extend the legacy interrupt workarounds Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272061459.5520.15.camel@achroite.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox