From mboxrd@z Thu Jan 1 00:00:00 1970 From: jamal Subject: Re: [PATCH net-next-2.6] net: speedup udp receive path Date: Sat, 01 May 2010 07:23:34 -0400 Message-ID: <1272713014.14499.21.camel@bigi> References: <1272010378-2955-1-git-send-email-xiaosuo@gmail.com> <20100427.150817.84390202.davem@davemloft.net> <1272406693.2343.26.camel@edumazet-laptop> <1272454432.14068.4.camel@bigi> <1272458001.2267.0.camel@edumazet-laptop> <1272458174.14068.16.camel@bigi> <1272463605.2267.70.camel@edumazet-laptop> <1272498293.4258.121.camel@bigi> <1272514176.2201.85.camel@edumazet-laptop> <1272540952.4258.161.camel@bigi> <1272545108.2222.65.camel@edumazet-laptop> <1272547061.4258.174.camel@bigi> <1272547307.2222.83.camel@edumazet-laptop> <1272548258.4258.185.camel@bigi> <1272548980.2222.87.camel@edumazet-laptop> <1272549408.4258.189.camel@bigi> <1272573383.3969.8.camel@bigi> <1272655814.3879.8.camel@bigi> <1272660000.2230.4.camel@edumazet-laptop> <1272672394.14499.1.camel@bigi> <1272693424.2230.75.camel@edumazet-laptop> Reply-To: hadi@cyberus.ca Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Changli Gao , David Miller , therbert@google.com, shemminger@vyatta.com, netdev@vger.kernel.org, Eilon Greenstein , Brian Bloniarz To: Eric Dumazet Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:41707 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800Ab0EALXx (ORCPT ); Sat, 1 May 2010 07:23:53 -0400 Received: by vws19 with SMTP id 19so780475vws.19 for ; Sat, 01 May 2010 04:23:51 -0700 (PDT) In-Reply-To: <1272693424.2230.75.camel@edumazet-laptop> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 2010-05-01 at 07:57 +0200, Eric Dumazet wrote: > I changed your program a bit to use EV_PERSIST, (to avoid epoll_ctl() > overhead for each packet...) Thats a different test case then ;-> You can also get rid of the timer (I doubt it will show much difference in results) - I have it in there because it i am trying to replicate what i saw causing the regression. > RPS off : 220.000 pps > > RPS on (ee mask) : 700.000 pps (with a slightly modified tg3 driver) > 96% of delivered packets > That's a very very huge gap. What were the numbers before you changed to EV_PERSIST? Note: i did not add any of your other patches for dst refcnt, sockets etc. Were you running with those patches in these tests? I will try the next opportunity i get to have latest kernel + those patches. > This is on tg3 adapter, and tg3 has copybreak feature : small packets > are copied into skb of the right size. Ok, so the driver tuning is also important then (and it shows in the profile). cheers, jamal