From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: [RFC] network driver skb allocations
Date: Mon, 03 May 2010 19:06:24 +0200 [thread overview]
Message-ID: <1272906384.2226.80.camel@edumazet-laptop> (raw)
Some performance idea about drivers and skb allocations :
-----------------------------------------------------------------------------------------------------------
PerfTop: 954 irqs/sec kernel:99.5% [1000Hz cycles], (all, cpu: 0)
-----------------------------------------------------------------------------------------------------------
samples pcnt function DSO
_______ _____ _____________________________ _________________
2378.00 16.3% __alloc_skb [kernel.kallsyms]
1962.00 13.5% eth_type_trans [kernel.kallsyms]
1472.00 10.1% __kmalloc_track_caller [kernel.kallsyms]
991.00 6.8% __slab_alloc [kernel.kallsyms]
938.00 6.4% _raw_spin_lock [kernel.kallsyms]
914.00 6.3% __netdev_alloc_skb [kernel.kallsyms]
876.00 6.0% kmem_cache_alloc [kernel.kallsyms]
519.00 3.6% tg3_poll_work [kernel.kallsyms]
416.00 2.9% tg3_read32 [kernel.kallsyms]
394.00 2.7% get_rps_cpu [kernel.kallsyms]
Current logic for drivers is to :
allocate skbs (sk_buff + data) and put them in a ring buffer.
When rx interrupt comes, get the skb and give it to stack.
Allocate a new skb (sk_buff + data) and put it in rx fat ring buffer (511 entries for tg3 )
This is suboptimal, because sk_buff will probably be cold 512 rx later...
Also, NUMA info might be wrong : sk_buff should be allocated on current node,
not on the device preferred node.
Drivers should allocate only the data part for NIC, and at the time of interrupt,
allocate the skb_buff and link it to buffer filled by NIC.
With a prefetch(first_cache_line_of_data) before doing sk_buff allocation and init,
eth_type_trans() / get_rps_cpus() would be much faster.
next reply other threads:[~2010-05-03 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 17:06 Eric Dumazet [this message]
2010-05-03 19:49 ` [RFC] network driver skb allocations Ben Hutchings
2010-05-03 20:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272906384.2226.80.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox