From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Johannes Weiner <jw@emlix.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexandros Batsakis <batsakis@netapp.com>,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch] sunrpc: add missing return statement
Date: Tue, 04 May 2010 08:27:22 -0400 [thread overview]
Message-ID: <1272976042.7559.24.camel@localhost.localdomain> (raw)
In-Reply-To: <20100504115759.266396633@emlix.com>
On Tue, 2010-05-04 at 13:59 +0200, Johannes Weiner wrote:
> f300bab "nfsd41: sunrpc: add new xprt class for nfsv4.1 backchannel"
> introduced an error case branch that lacks an actual `return' keyword
> before the return value. Add it.
>
> Signed-off-by: Johannes Weiner <jw@emlix.com>
> Cc: Alexandros Batsakis <batsakis@netapp.com>
> ---
> net/sunrpc/xprtsock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/net/sunrpc/xprtsock.c
> +++ b/net/sunrpc/xprtsock.c
> @@ -2444,7 +2444,7 @@ static struct rpc_xprt *xs_setup_bc_tcp(
> struct svc_sock *bc_sock;
>
> if (!args->bc_xprt)
> - ERR_PTR(-EINVAL);
> + return ERR_PTR(-EINVAL);
>
> xprt = xs_setup_xprt(args, xprt_tcp_slot_table_entries);
> if (IS_ERR(xprt))
No. It should either be a BUG_ON(), or else be removed entirely.
Returning an error value for something that is clearly a programming bug
is not a particularly useful exercise...
Cheers
Trond
next prev parent reply other threads:[~2010-05-04 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 11:59 [patch] sunrpc: add missing return statement Johannes Weiner
2010-05-04 12:27 ` Trond Myklebust [this message]
[not found] ` <1272976042.7559.24.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-05-04 13:03 ` Tetsuo Handa
2010-05-04 13:13 ` Trond Myklebust
[not found] ` <1272978815.7559.27.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-05-04 14:02 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272976042.7559.24.camel@localhost.localdomain \
--to=trond.myklebust@fys.uio.no \
--cc=batsakis@netapp.com \
--cc=davem@davemloft.net \
--cc=jw@emlix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox