From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: mmotm 2010-04-28 - RCU whinges Date: Mon, 10 May 2010 17:57:31 +0200 Message-ID: <1273507052.2221.20.camel@edumazet-laptop> References: <1272865137.2173.179.camel@edumazet-laptop> <1272865267.2173.180.camel@edumazet-laptop> <1272865436.2173.182.camel@edumazet-laptop> <20100502.225509.233880079.davem@davemloft.net> <4BE8290A.2080707@trash.net> <1273506968.2221.19.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , Valdis.Kletnieks@vt.edu, akpm@linux-foundation.org, peterz@infradead.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, paulmck@linux.vnet.ibm.com To: Patrick McHardy Return-path: In-Reply-To: <1273506968.2221.19.camel@edumazet-laptop> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Le lundi 10 mai 2010 =C3=A0 17:56 +0200, Eric Dumazet a =C3=A9crit : > Le lundi 10 mai 2010 =C3=A0 17:40 +0200, Patrick McHardy a =C3=A9crit= : > > David Miller wrote: > > > From: Eric Dumazet > > > Date: Mon, 03 May 2010 07:43:56 +0200 > > >=20 > > >> Le lundi 03 mai 2010 =C3=A0 07:41 +0200, Eric Dumazet a =C3=A9cr= it : > > >> > > >>> Oops scratch that, I'll resend a correct version. > > >>> > > >>> > > >> Sorry, patch _is_ fine, I had one brain collapse when re-reading= it, I > > >> thought a different mutex was in use in one of the functions. > > >=20 > > > Ok, Patrick please review, thanks. > >=20 > > Actually we don't need the rcu_dereference() calls at all since > > registration and unregistration are protected by the mutexes. > >=20 > > I queued this patch in nf-next, the only reason why I haven't > > submitted it yet is that I was unable to get git to cleanly export > > only the proper set of patches meant for -next due to a few merges, > > it insists on including 5 patches already merged upstream. If you > > don't mind ignoring the first 5 patches in the series, I'll send a > > pull request tonight. > >=20 >=20 >=20 > This will clash with upcoming RCU patches, where rcu protected pointe= r > cannot be directly accessed without lockdep splats. >=20 Sorry, I meant sparse here, not lockdep. > We will need one day or another a rcu_...(nf_conntrack_event_cb)