Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: eilong@broadcom.com
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Vladislav Zolotarov <vladz@broadcom.com>,
	Dmitry Kravkov <dmitry@broadcom.com>,
	Michael Chan <mchan@broadcom.com>,
	Breno Leitao <leitao@linux.vnet.ibm.com>,
	Matthew Carlson <mcarlson@broadcom.com>
Subject: Re: [PATCH net-next] bnx2x: avoid TX timeout when stopping device
Date: Wed, 12 May 2010 14:37:43 +0200	[thread overview]
Message-ID: <1273667863.2621.28.camel@edumazet-laptop> (raw)
In-Reply-To: <1273663155.5948.7.camel@lb-tlvb-eilong.il.broadcom.com>

Le mercredi 12 mai 2010 à 14:19 +0300, Eilon Greenstein a écrit :

> Eric,
> 
> I thought that your 1ae5dc342ac78d7a42965fd1f323815f6f5ef2c1 commit took
> care of trans_start, right? Well, actually the commit that made it
> possible to remove the trans_start manipulation.

Its only part of the (huge) job, started last year with 10GB and GB
nics.

My intent was to take care of not touching dev->trans_start in
start_xmit() method, then take care of other cases later.




      reply	other threads:[~2010-05-12 12:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-12  9:09 [PATCH net-next] bnx2x: avoid TX timeout when stopping device Stanislaw Gruszka
2010-05-12  9:27 ` Eric Dumazet
2010-05-12 10:58   ` Stanislaw Gruszka
2010-05-12 11:06     ` [RFC PATCH] bnx2: use netif_carrier_off to prevent tx timeout Stanislaw Gruszka
2010-05-12 11:16       ` [RFC PATCH] tg3: " Stanislaw Gruszka
2010-05-12 13:31       ` [RFC PATCH] bnx2: " Michael Chan
2010-05-12 14:00         ` Stanislaw Gruszka
2010-05-12 14:09           ` Michael Chan
2010-05-12 11:19     ` [PATCH net-next] bnx2x: avoid TX timeout when stopping device Eilon Greenstein
2010-05-12 12:37       ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273667863.2621.28.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=dmitry@broadcom.com \
    --cc=eilong@broadcom.com \
    --cc=leitao@linux.vnet.ibm.com \
    --cc=mcarlson@broadcom.com \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    --cc=vladz@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox