netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] net sched: cleanup and rate limit warning
Date: Wed, 12 May 2010 15:13:48 -0400	[thread overview]
Message-ID: <1273691628.16074.15.camel@bigi> (raw)
In-Reply-To: <20100512111706.616dc7cf@nehalam>

Thanks for the info Stephen.

On Wed, 2010-05-12 at 11:17 -0700, Stephen Hemminger wrote:

> The Vyatta syntax is:
> 
>  traffic-limiter test-traffic-limit {
>      class 2048 {
>          bandwidth 1mbit
>          burst 500kbit
>          match onebox {
>              ip {
>                  destination {
>                      address 192.168.100.99/32
>                  }
>              }
>          }
>      }
>  }
> 

;-> I guess kids these days prefer juniperism over ciscoism?
Why dont they just learn linuxism?;->

> Which generates these TC commands.
> 
> root@VC6:~# tc qdisc show dev eth0
> qdisc pfifo_fast 0: root bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
> qdisc ingress ffff: parent ffff:fff1 ---------------- 
> 
> root@VC6:~# tc filter show dev eth0 parent ffff:
> filter protocol all pref 20 u32 
> filter protocol all pref 20 u32 fh 800: ht divisor 1 
> filter protocol all pref 20 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid ffff:800 
>   match c0a86463/ffffffff at 16
>  police 0x3 rate 1000Kbit burst 63999b mtu 2Kb action reclassify overhead 0b 
> ref 1 bind 1
> 
> 
> I think the bad part is the huge burst size.

That may be - but it seems your tool is the culprit.
It is generating wrong tc commands if i read the intent correctly.
Basically what the tc command is saying is "if you exceed the 1Mbit upto
a burst of 500kbit then reclassify".
"Reclassify" means literally that: to reuse the same classification rule
again, which will find that  we have exceeded 1M which will ask
reclassify .... loop.... I am glad that code is there ;->

cheers,
jamal


  reply	other threads:[~2010-05-12 19:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-12  0:24 [PATCH] net sched: cleanup and rate limit warning Stephen Hemminger
2010-05-12 17:17 ` jamal
2010-05-12 18:17   ` Stephen Hemminger
2010-05-12 19:13     ` jamal [this message]
2010-05-12 20:20       ` Stephen Hemminger
2010-05-12 20:41         ` jamal
2010-05-13 13:12           ` Patrick McHardy
2010-05-13 16:20             ` jamal
2010-05-13 16:26               ` Stephen Hemminger
2010-05-13 16:40                 ` jamal
2010-05-18  6:06                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273691628.16074.15.camel@bigi \
    --to=hadi@cyberus.ca \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).