From mboxrd@z Thu Jan  1 00:00:00 1970
From: jamal <hadi@cyberus.ca>
Subject: Re: [PATCH] net sched: cleanup and rate limit warning
Date: Wed, 12 May 2010 15:13:48 -0400
Message-ID: <1273691628.16074.15.camel@bigi>
References: <20100511172412.76aff184@nehalam>
	 <1273684674.16074.0.camel@bigi>  <20100512111706.616dc7cf@nehalam>
Reply-To: hadi@cyberus.ca
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
To: Stephen Hemminger <shemminger@vyatta.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-fx0-f46.google.com ([209.85.161.46]:61566 "EHLO
	mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756666Ab0ELTUC (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 12 May 2010 15:20:02 -0400
Received: by fxm5 with SMTP id 5so4091fxm.19
        for <netdev@vger.kernel.org>; Wed, 12 May 2010 12:20:01 -0700 (PDT)
In-Reply-To: <20100512111706.616dc7cf@nehalam>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Thanks for the info Stephen.

On Wed, 2010-05-12 at 11:17 -0700, Stephen Hemminger wrote:

> The Vyatta syntax is:
> 
>  traffic-limiter test-traffic-limit {
>      class 2048 {
>          bandwidth 1mbit
>          burst 500kbit
>          match onebox {
>              ip {
>                  destination {
>                      address 192.168.100.99/32
>                  }
>              }
>          }
>      }
>  }
> 

;-> I guess kids these days prefer juniperism over ciscoism?
Why dont they just learn linuxism?;->

> Which generates these TC commands.
> 
> root@VC6:~# tc qdisc show dev eth0
> qdisc pfifo_fast 0: root bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
> qdisc ingress ffff: parent ffff:fff1 ---------------- 
> 
> root@VC6:~# tc filter show dev eth0 parent ffff:
> filter protocol all pref 20 u32 
> filter protocol all pref 20 u32 fh 800: ht divisor 1 
> filter protocol all pref 20 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid ffff:800 
>   match c0a86463/ffffffff at 16
>  police 0x3 rate 1000Kbit burst 63999b mtu 2Kb action reclassify overhead 0b 
> ref 1 bind 1
> 
> 
> I think the bad part is the huge burst size.

That may be - but it seems your tool is the culprit.
It is generating wrong tc commands if i read the intent correctly.
Basically what the tc command is saying is "if you exceed the 1Mbit upto
a burst of 500kbit then reclassify".
"Reclassify" means literally that: to reuse the same classification rule
again, which will find that  we have exceeded 1M which will ask
reclassify .... loop.... I am glad that code is there ;->

cheers,
jamal