From: jamal <hadi@cyberus.ca>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH] net sched: cleanup and rate limit warning
Date: Wed, 12 May 2010 16:41:43 -0400 [thread overview]
Message-ID: <1273696903.16074.25.camel@bigi> (raw)
In-Reply-To: <20100512132042.3b38da18@nehalam>
On Wed, 2010-05-12 at 13:20 -0700, Stephen Hemminger wrote:
> The tool isn't generating an action (just tc filter ... police ..)
> so it is getting the unfortunate default of reclassify.
Ah ok.
My advice: you should never ever depend on defaults when you
can be explicit and say "drop". Or have the users in your tool be able
to specify what action to take if rate is exceeded etc (actually i think
juniper does that)
I think "drop" would be the sane default for over-limit - my memory is
hazy because i assumed that was the default but there may have been some
reservations on that default. Patrick?
cheers,
jamal
next prev parent reply other threads:[~2010-05-12 20:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 0:24 [PATCH] net sched: cleanup and rate limit warning Stephen Hemminger
2010-05-12 17:17 ` jamal
2010-05-12 18:17 ` Stephen Hemminger
2010-05-12 19:13 ` jamal
2010-05-12 20:20 ` Stephen Hemminger
2010-05-12 20:41 ` jamal [this message]
2010-05-13 13:12 ` Patrick McHardy
2010-05-13 16:20 ` jamal
2010-05-13 16:26 ` Stephen Hemminger
2010-05-13 16:40 ` jamal
2010-05-18 6:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273696903.16074.25.camel@bigi \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).