From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: netdev@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>,
linux-arm-kernel@lists.infradead.org,
Herbert Valerio Riedel <hvr@gnu.org>
Subject: Re: [PATCH] phy/marvell: Add special settings for D-Link DNS-323 rev C1
Date: Mon, 17 May 2010 22:08:17 +1000 [thread overview]
Message-ID: <1274098097.21352.737.camel@pasglop> (raw)
In-Reply-To: <20100517120032.GI22781@pengutronix.de>
On Mon, 2010-05-17 at 14:00 +0200, Wolfram Sang wrote:
> > The problem is that the fixups are called -after- the config_init()
> > callback of the PHY driver. However, the marvell m88e1118 PHY driver
> > will unconditionally reset the LEDs setting.
>
> Haven't checked, just an idea: Is it possible to change the init of
> the driver to use Read-Modify-Write and thus keep your settings?
Well, the driver just unconditionally blasts the whole register and
the value I want to put there is also a "raw" value of the whole
register based on what the vendor code puts in there (in their old
2.6.12 based port).
So with only that at hand and no documentation for the actual PHY chip,
I don't see a simple solution here.
Cheers,
Ben.
prev parent reply other threads:[~2010-05-17 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 0:27 [PATCH] phy/marvell: Add special settings for D-Link DNS-323 rev C1 Benjamin Herrenschmidt
2010-05-17 0:59 ` Wolfram Sang
2010-05-17 1:07 ` Benjamin Herrenschmidt
2010-05-17 11:36 ` Benjamin Herrenschmidt
2010-05-17 12:00 ` Wolfram Sang
2010-05-17 12:08 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274098097.21352.737.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=hvr@gnu.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).