Re: tun: Use netif_receive_skb instead of netif_rx

Neil Horman
2010-05-21T16:41:06Z

On Fri, May 21, 2010 at 09:08:47PM +1000, Herbert Xu wrote:
> On Fri, May 21, 2010 at 06:51:28AM -0400, Neil Horman wrote:
> >
> > I read it, we just described the issue in diferent terms.
>
> Yeah I wasn't clear enough with my email without an actual patch :)
>
> Thanks for testing Neil!

So a bit of bad news. I think you're patch is correct herbert but its still not
working. When I initially started messing with this it was on 2.6.32. But
since you're patches I (naturally) started testing them on 2.6.34. Whereas in
2.6.32 the tasks classid value for the net_cls cgroup subsys was set properly,
in 2.6.34 its not. It appears since we started using the cgroup subsys
registration calls, we never registered an attach method, so we never set the
tasks classid, so the comparison always fails.

There may also be an issue with the setting of the classid (possible use of the
wrong subsys id value when grabbing our cgroup_subsys_state), but I'm checking
on that now.

Best
Neil

> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
>