Re: tun: Use netif_receive_skb instead of netif_rx

Neil Horman
2010-05-21T00:39:51Z

On Fri, May 21, 2010 at 09:16:30AM +1000, Herbert Xu wrote:
> On Thu, May 20, 2010 at 01:29:18PM -0400, Neil Horman wrote:
> >
> > So, I'm testing this patch out now, and unfotunately it doesn't seem to be
> > working. Every frame seems to be holding a classid of 0. Trying to figure out
> > why now.
>
> Not very surprising since tun.c doesn't go through the normal
> socket interface. I'll send a additional patch for that.
>
I don't think thats it. I think its a chicken and egg situation. I think the
problem is that tasks can't be assigned to cgroups until their created, and in
that time a sock can be created. Its a natural race. If you create a socket
before you assign it to a cgroup, that socket retains a classid of zero. I'm
going to try modify the patch to update sockets owned by tasks when the cgroup
is assigned.

Best
Neil

> Cheers,
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
>