Re: cls_cgroup: Store classid in struct sock

Neil Horman
2010-05-22T12:26:44Z

On Sat, May 22, 2010 at 11:49:57AM +1000, Herbert Xu wrote:
> On Fri, May 21, 2010 at 12:40:54PM -0400, Neil Horman wrote:
> >
> > There may also be an issue with the setting of the classid (possible use of the
> > wrong subsys id value when grabbing our cgroup_subsys_state), but I'm checking
> > on that now.
>
> Actually, I think it's because my patch mistook CONFIG_CGROUP
> for CONFIG_CGROUPS.
>
Thats definately part of it yes. But its not all of it, although I think the
rest doesn't have anything to do with your patch. I fixed that straight away,
but I was still alwasy getting classids of zero in the qemu processes. Looking
at the cgroup classifier, I'm wondering how this cgroup code ever worked in the
first place. When we register the cgroup subsystem, we don't register an attach
method, so we never get a chance to assign task_cls_sate(tsk)->classid to any
non-zero value. I've got a version of the patch that add that, but for some
reason, even though I set task_cls_state(tsk)->classid to the cgroup classid on
attach, task_cls_classid still returns zero. I'm not sure why that is yet, but
I'm looking into it.

Neil

>