From: xiaohui.xin@intel.com
To: netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mst@redhat.com, mingo@elte.hu,
davem@davemloft.net, jdike@linux.intel.com
Cc: Xin Xiaohui <xiaohui.xin@intel.com>
Subject: [RFC][PATCH v6 09/19] Ignore room skb_reserve() when device is using external buffer.
Date: Fri, 21 May 2010 17:30:25 +0800 [thread overview]
Message-ID: <1274434235-5929-10-git-send-email-xiaohui.xin@intel.com> (raw)
In-Reply-To: <1274434235-5929-9-git-send-email-xiaohui.xin@intel.com>
From: Xin Xiaohui <xiaohui.xin@intel.com>
Make the skb->data and skb->head from external buffer
to be consistent, we ignore the room reserved by driver
for kernel skb.
Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com>
Signed-off-by: Zhao Yu <yzhao81new@gmail.com>
Reviewed-by: Jeff Dike <jdike@linux.intel.com>
---
include/linux/skbuff.h | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 5ff8c27..193b259 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -1200,6 +1200,15 @@ static inline int skb_tailroom(const struct sk_buff *skb)
*/
static inline void skb_reserve(struct sk_buff *skb, int len)
{
+ /* Since skb_reserve() is only for an empty buffer,
+ * and when the skb is getting external buffer, we cannot
+ * retain the external buffer has the same reserved space
+ * in the header which kernel allocatd skb has, so have to
+ * ignore this. And we have recorded the external buffer
+ * info in the destructor_arg field, so use it as indicator.
+ */
+ if (skb_shinfo(skb)->destructor_arg)
+ return;
skb->data += len;
skb->tail += len;
}
--
1.5.4.4
next prev parent reply other threads:[~2010-05-21 9:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 9:30 [RFC][PATCH v6 00/19] Provide a zero-copy method on KVM virtio-net xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 01/19] Add a new structure for skb buffer from external xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 02/19] Add a new struct for device to manipulate external buffer xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 03/19] Export 2 func for device to assign/deassign new strucure xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 04/19] Add a ndo_mp_port_prep pointer to net_device_ops xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 05/19] Add a function make external buffer owner to query capability xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 06/19] Add a function to indicate if device use external buffer xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 07/19] Add interface to get external buffers xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 08/19] Make __alloc_skb() to get external buffer xiaohui.xin
2010-05-21 9:30 ` xiaohui.xin [this message]
2010-05-21 9:30 ` [RFC][PATCH v6 10/19] Don't do skb recycle, if device use " xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 11/19] Use callback to deal with skb_release_data() specially xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 12/19] Add a hook to intercept external buffers from NIC driver xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 13/19] To skip GRO if buffer is external currently xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 14/19] Add header file for mp device xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 15/19] Add basic funcs and ioctl to " xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 16/19] Manipulate external buffers in " xiaohui.xin
2010-05-21 9:30 ` [PATCH v6 17/19] Export proto_ops to vhost-net driver xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 18/19] Add a kconfig entry and make entry for mp device xiaohui.xin
2010-05-21 9:30 ` [RFC][PATCH v6 19/19] Provides multiple submits and asynchronous notifications xiaohui.xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274434235-5929-10-git-send-email-xiaohui.xin@intel.com \
--to=xiaohui.xin@intel.com \
--cc=davem@davemloft.net \
--cc=jdike@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).