netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: xiaohui.xin@intel.com
To: netdev@vger.kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, mst@redhat.com, mingo@elte.hu,
	davem@davemloft.net, jdike@linux.intel.com
Cc: Xin Xiaohui <xiaohui.xin@intel.com>
Subject: [RFC][PATCH v6 05/19] Add a function make external buffer owner to query capability.
Date: Fri, 21 May 2010 17:30:21 +0800	[thread overview]
Message-ID: <1274434235-5929-6-git-send-email-xiaohui.xin@intel.com> (raw)
In-Reply-To: <1274434235-5929-5-git-send-email-xiaohui.xin@intel.com>

From: Xin Xiaohui <xiaohui.xin@intel.com>

The external buffer owner can use the functions to get
the capability of the underlying NIC driver.

Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com>
Signed-off-by: Zhao Yu <yzhaonew@gmail.com>
Reviewed-by: Jeff Dike <jdike@linux.intel.com>
---
 include/linux/netdevice.h |    2 +
 net/core/dev.c            |   51 +++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 53 insertions(+), 0 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 183c786..31d9c4a 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1599,6 +1599,8 @@ extern gro_result_t	napi_gro_frags(struct napi_struct *napi);
 extern int netdev_mp_port_attach(struct net_device *dev,
 				 struct mpassthru_port *port);
 extern void netdev_mp_port_detach(struct net_device *dev);
+extern int netdev_mp_port_prep(struct net_device *dev,
+			struct mpassthru_port *port);
 
 static inline void napi_free_frags(struct napi_struct *napi)
 {
diff --git a/net/core/dev.c b/net/core/dev.c
index ecbb6b1..37b389a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2497,6 +2497,57 @@ void netdev_mp_port_detach(struct net_device *dev)
 }
 EXPORT_SYMBOL(netdev_mp_port_detach);
 
+/* To support meidate passthru(zero-copy) with NIC driver,
+ * we'd better query NIC driver for the capability it can
+ * provide, especially for packet split mode, now we only
+ * query for the header size, and the payload a descriptor
+ * may carry. If a driver does not use the API to export,
+ * then we may try to use a default value, currently,
+ * we use the default value from an IGB driver. Now,
+ * it's only called by mpassthru device.
+ */
+#if defined(CONFIG_MEDIATE_PASSTHRU) || defined(CONFIG_MEDIATE_PASSTHRU_MODULE)
+int netdev_mp_port_prep(struct net_device *dev,
+			struct mpassthru_port *port)
+{
+	int rc;
+	int npages, data_len;
+	const struct net_device_ops *ops = dev->netdev_ops;
+
+	/* needed by packet split */
+
+	if (ops->ndo_mp_port_prep) {
+		rc = ops->ndo_mp_port_prep(dev, port);
+		if (rc)
+			return rc;
+	} else {
+		/* If the NIC driver did not report this,
+		 * then we try to use default value.
+		 */
+		port->hdr_len = 128;
+		port->data_len = 2048;
+		port->npages = 1;
+	}
+
+	if (port->hdr_len <= 0)
+		goto err;
+
+	npages = port->npages;
+	data_len = port->data_len;
+	if (npages <= 0 || npages > MAX_SKB_FRAGS ||
+			(data_len < PAGE_SIZE * (npages - 1) ||
+			 data_len > PAGE_SIZE * npages))
+		goto err;
+
+	return 0;
+err:
+	dev_warn(&dev->dev, "invalid page constructor parameters\n");
+
+	return -EINVAL;
+}
+EXPORT_SYMBOL(netdev_mp_port_prep);
+#endif
+
 /**
  *	netif_receive_skb - process receive buffer from network
  *	@skb: buffer to process
-- 
1.5.4.4


  reply	other threads:[~2010-05-21  9:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21  9:30 [RFC][PATCH v6 00/19] Provide a zero-copy method on KVM virtio-net xiaohui.xin
2010-05-21  9:30 ` [RFC][PATCH v6 01/19] Add a new structure for skb buffer from external xiaohui.xin
2010-05-21  9:30   ` [RFC][PATCH v6 02/19] Add a new struct for device to manipulate external buffer xiaohui.xin
2010-05-21  9:30     ` [RFC][PATCH v6 03/19] Export 2 func for device to assign/deassign new strucure xiaohui.xin
2010-05-21  9:30       ` [RFC][PATCH v6 04/19] Add a ndo_mp_port_prep pointer to net_device_ops xiaohui.xin
2010-05-21  9:30         ` xiaohui.xin [this message]
2010-05-21  9:30           ` [RFC][PATCH v6 06/19] Add a function to indicate if device use external buffer xiaohui.xin
2010-05-21  9:30             ` [RFC][PATCH v6 07/19] Add interface to get external buffers xiaohui.xin
2010-05-21  9:30               ` [RFC][PATCH v6 08/19] Make __alloc_skb() to get external buffer xiaohui.xin
2010-05-21  9:30                 ` [RFC][PATCH v6 09/19] Ignore room skb_reserve() when device is using " xiaohui.xin
2010-05-21  9:30                   ` [RFC][PATCH v6 10/19] Don't do skb recycle, if device use " xiaohui.xin
2010-05-21  9:30                     ` [RFC][PATCH v6 11/19] Use callback to deal with skb_release_data() specially xiaohui.xin
2010-05-21  9:30                       ` [RFC][PATCH v6 12/19] Add a hook to intercept external buffers from NIC driver xiaohui.xin
2010-05-21  9:30                         ` [RFC][PATCH v6 13/19] To skip GRO if buffer is external currently xiaohui.xin
2010-05-21  9:30                           ` [RFC][PATCH v6 14/19] Add header file for mp device xiaohui.xin
2010-05-21  9:30                             ` [RFC][PATCH v6 15/19] Add basic funcs and ioctl to " xiaohui.xin
2010-05-21  9:30                               ` [RFC][PATCH v6 16/19] Manipulate external buffers in " xiaohui.xin
2010-05-21  9:30                                 ` [PATCH v6 17/19] Export proto_ops to vhost-net driver xiaohui.xin
2010-05-21  9:30                                   ` [RFC][PATCH v6 18/19] Add a kconfig entry and make entry for mp device xiaohui.xin
2010-05-21  9:30                                     ` [RFC][PATCH v6 19/19] Provides multiple submits and asynchronous notifications xiaohui.xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274434235-5929-6-git-send-email-xiaohui.xin@intel.com \
    --to=xiaohui.xin@intel.com \
    --cc=davem@davemloft.net \
    --cc=jdike@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).