From: jamal <hadi@cyberus.ca>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Jiri Pirko <jpirko@redhat.com>,
netdev@vger.kernel.org, davem@davemloft.net, kaber@trash.net
Subject: Re: Question about an assignment in handle_ing()
Date: Tue, 25 May 2010 09:13:36 -0400 [thread overview]
Message-ID: <1274793216.3878.947.camel@bigi> (raw)
In-Reply-To: <20100525124636.GA13161@gondor.apana.org.au>
On Tue, 2010-05-25 at 22:46 +1000, Herbert Xu wrote:
> That's not very surprising as you're not checking whether the
> skb is cloned in act_pedit.c:
I meant the test "if (skb_cloned(skb))" failed in such cases;-> So you
couldnt reliably use it.
If it turns out it is unnecessary, what you describe is what i had in
mind as well.
> BTW, this error handling also looks a bit suss. Shouldn't it
> drop the packet instead of continuing as if we have successfully
> modified it?
It is not the responsibility of the action to drop packets in a pipeline
rather the responsibility is that of the caller (ref: rule #3 in
Documentation/networking/tc-actions-env-rules.txt). What to do on a
failure such as above is programmable by the action user/admin.
Anyways, now i am really gone. Dont make me look in again Herbert ;->
cheers,
jamal
next prev parent reply other threads:[~2010-05-25 13:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-24 11:22 Question about an assignment in handle_ing() Jiri Pirko
2010-05-25 9:51 ` jamal
2010-05-25 10:26 ` Herbert Xu
2010-05-25 12:03 ` jamal
2010-05-25 12:12 ` Herbert Xu
2010-05-25 12:20 ` jamal
2010-05-25 12:46 ` Herbert Xu
2010-05-25 13:13 ` jamal [this message]
2010-05-25 23:13 ` Herbert Xu
2010-05-26 11:38 ` jamal
2010-05-30 13:29 ` jamal
2010-06-03 8:01 ` Herbert Xu
2010-06-03 12:43 ` jamal
2010-06-03 12:47 ` Herbert Xu
2010-06-03 12:53 ` jamal
2010-06-03 12:56 ` Herbert Xu
2010-06-03 12:58 ` Herbert Xu
2010-06-03 12:58 ` jamal
2010-06-03 13:00 ` Herbert Xu
2010-06-03 13:01 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274793216.3878.947.camel@bigi \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jpirko@redhat.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox