Re: NULL Pointer Deference: NFS & Telnet

David Miller
2010-06-04T23:15:30Z

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 26 May 2010 22:48:53 +0200

> Le mercredi 26 mai 2010 à 15:19 -0500, Arce, Abraham a écrit :
>
>> By increasing the allocation length of our rx skbuff the corruption issue is fixed... I have increased it by 2... Were we writing outside our boundaries of skb data?
>>
>> Please let me know about this approach...
>>
>> diff --git a/drivers/net/ks8851.c b/drivers/net/ks8851.c
>> index b4fb07a..6da81e1 100644
>> --- a/drivers/net/ks8851.c
>> +++ b/drivers/net/ks8851.c
>> @@ -504,7 +504,7 @@ static void ks8851_rx_pkts(struct ks8851_net *ks)
>> ks->rc_rxqcr | RXQCR_SDA | RXQCR_ADRFE);
>>
>> if (rxlen > 0) {
>> - skb = netdev_alloc_skb(ks->netdev, rxlen + 2 + 8);
>> + skb = netdev_alloc_skb(ks->netdev, rxlen + 4 + 8);
>> if (!skb) {
>>
>> Best Regards
>> Abraham
>>
>
> Yes that makes sense, nr_frag is right after the packet (padded to L1
> cache size)
>
> But please do the correct allocation ?
>
> Also, we dont need FCS ?

Can we make some progress and get this patch tested and formally
submitted so we can kill this bug?

Thanks!