From: jamal <hadi@cyberus.ca>
To: David Miller <davem@davemloft.net>
Cc: xiaosuo@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] cls_u32: use skb_copy_bits() to dereference data safely
Date: Wed, 02 Jun 2010 09:47:06 -0400 [thread overview]
Message-ID: <1275486426.3545.6.camel@bigi> (raw)
In-Reply-To: <20100602.064316.218079399.davem@davemloft.net>
On Wed, 2010-06-02 at 06:43 -0700, David Miller wrote:
> From: jamal <hadi@cyberus.ca>
> >
> > A little worse than skb_copy_bits(). In any case, this change is going
> > to hurt.
>
> Umm, Jamal what are you talking about?
;->
> Using skb_header_pointer(), if the offset is in range, there is no
> change from today other than a comparison.
Thats the part i glossed over - My eyes just saw "it calls
skb_copy_bits()" ;->
> If it is not in range, we use skb_copy_bits(). It's only for the
> case where we have to fetch the value from the fragmented part
> of the SKB.
cheers,
jamal
next prev parent reply other threads:[~2010-06-02 13:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 2:24 [PATCH] cls_u32: use skb_copy_bits() to dereference data safely Changli Gao
2010-06-01 12:34 ` jamal
2010-06-01 17:47 ` Changli Gao
2010-06-02 12:20 ` jamal
2010-06-02 12:25 ` jamal
2010-06-02 12:45 ` David Miller
2010-06-02 13:14 ` Changli Gao
2010-06-02 13:27 ` David Miller
2010-06-02 13:36 ` jamal
2010-06-02 13:43 ` Changli Gao
2010-06-02 13:48 ` jamal
2010-06-02 13:43 ` David Miller
2010-06-02 13:47 ` jamal [this message]
2010-06-02 12:47 ` David Miller
2010-06-02 13:17 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275486426.3545.6.camel@bigi \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).