From: Changli Gao <xiaosuo@gmail.com>
To: Jamal Hadi Salim <hadi@cyberus.ca>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Changli Gao <xiaosuo@gmail.com>
Subject: cls_u32: check unaligned data access
Date: Wed, 2 Jun 2010 23:15:47 +0800 [thread overview]
Message-ID: <1275491747-29888-1-git-send-email-xiaosuo@gmail.com> (raw)
check unaligned data access
before accessing data, check if the corresponding address is aligned, and if
not, return -1.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
----
net/sched/cls_u32.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index 4f52214..309d275 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -102,7 +102,8 @@ static int u32_classify(struct sk_buff *skb, struct tcf_proto *tp, struct tcf_re
} stack[TC_U32_MAXDEPTH];
struct tc_u_hnode *ht = (struct tc_u_hnode*)tp->root;
- unsigned int off = skb_network_offset(skb);
+ unsigned int noff = skb_network_offset(skb);
+ unsigned int off = noff;
struct tc_u_knode *n;
int sdepth = 0;
int off2 = 0;
@@ -138,6 +139,8 @@ next_knode:
__be32 *data, _data;
toff = off + key->off + (off2 & key->offmask);
+ if ((toff - noff) % 4)
+ goto out;
data = skb_header_pointer(skb, toff, 4, &_data);
if (!data)
goto out;
@@ -188,6 +191,8 @@ check_terminal:
if (ht->divisor) {
__be32 *data, _data;
+ if ((off + n->sel.hoff - noff) % 4)
+ goto out;
data = skb_header_pointer(skb, off + n->sel.hoff, 4,
&_data);
if (!data)
@@ -203,6 +208,8 @@ check_terminal:
if (n->sel.flags & TC_U32_VAROFFSET) {
__be16 *data, _data;
+ if ((off + n->sel.offoff - noff) % 2)
+ goto out;
data = skb_header_pointer(skb,
off + n->sel.offoff,
2, &_data);
next reply other threads:[~2010-06-02 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 15:15 Changli Gao [this message]
2010-06-02 15:18 ` cls_u32: check unaligned data access David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275491747-29888-1-git-send-email-xiaosuo@gmail.com \
--to=xiaosuo@gmail.com \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).