netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Junchang Wang <junchangwang@gmail.com>
Cc: romieu@fr.zoreil.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [Patch 2/2]r8169: remove redundant RTL_W32
Date: Thu, 03 Jun 2010 13:40:10 +0100	[thread overview]
Message-ID: <1275568810.2870.90.camel@localhost> (raw)
In-Reply-To: <20100603112721.GD24909@host-a-55.ustcsz.edu.cn>

On Thu, 2010-06-03 at 19:27 +0800, Junchang Wang wrote:
> Writting "cmd" into "CounterAddrLow" twice is redundant.
[...]

I assume you've checked this against the datasheets for all 20 variants
of this hardware?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  reply	other threads:[~2010-06-03 12:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-03 11:27 [Patch 2/2]r8169: remove redundant RTL_W32 Junchang Wang
2010-06-03 12:40 ` Ben Hutchings [this message]
2010-06-03 19:29 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275568810.2870.90.camel@localhost \
    --to=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=junchangwang@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).