From: Joe Perches <joe@perches.com>
To: Scott Feldman <scofeldm@cisco.com>
Cc: netdev <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [net-next PATCH] drivers/net/enic: Use (pr|netdev)_<level> macro helpers
Date: Thu, 03 Jun 2010 08:11:24 -0700 [thread overview]
Message-ID: <1275577884.1703.11.camel@Joe-Laptop.home> (raw)
In-Reply-To: <C82CA5A9.3677A%scofeldm@cisco.com>
On Thu, 2010-06-03 at 00:19 -0700, Scott Feldman wrote:
> I like the dev_name(dev) in there but not the "(unregister net_device)".
> Also there where a couple of lines longer than 80 chars.
> We can fix up the patch and resubmit if you like.
I'm not constrained by 80 char lines for formats.
Have at it. Fix it up to your liking.
cheers, Joe
prev parent reply other threads:[~2010-06-03 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 15:30 [net-next PATCH] drivers/net/enic: Use (pr|netdev)_<level> macro helpers Joe Perches
2010-06-03 7:19 ` Scott Feldman
2010-06-03 15:11 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275577884.1703.11.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=scofeldm@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).