From: Joe Perches <joe@perches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, gospo@redhat.com,
Emil Tantilov <emil.s.tantilov@intel.com>
Subject: Re: [net-next-2.6 PATCH] ixgbe: Use netdev_<level>, dev_<level>, pr_<level>
Date: Thu, 03 Jun 2010 20:20:05 -0700 [thread overview]
Message-ID: <1275621605.1703.38.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100604025225.16120.30293.stgit@localhost.localdomain>
On Thu, 2010-06-03 at 19:53 -0700, Jeff Kirsher wrote:
> From: Emil Tantilov <emil.s.tantilov@intel.com>
Hi Emil.
> This patch is alternative to a previous patch submitted by Joe Perches.
Why eliminate all the adapter->msg_enable tests?
There are many changes like this. For instance:
> if (link_up && (link_speed == IXGBE_LINK_SPEED_1GB_FULL))
> - netif_info(adapter, hw, adapter->netdev, "Smartspeed has"
> - " downgraded the link speed from the maximum"
> - " advertised\n");
> + e_info("Smartspeed has downgraded the link speed from "
> + "the maximum advertised\n");
This was only printed when NETIF_MSG_HW was set,
now it's always printed.
next prev parent reply other threads:[~2010-06-04 3:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 2:53 [net-next-2.6 PATCH] ixgbe: Use netdev_<level>, dev_<level>, pr_<level> Jeff Kirsher
2010-06-04 3:04 ` David Miller
2010-06-04 3:15 ` Jeff Kirsher
2010-06-04 3:20 ` Joe Perches [this message]
2010-06-04 23:44 ` Tantilov, Emil S
2010-06-05 5:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275621605.1703.38.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=emil.s.tantilov@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox