* [PATCH net-next-2.6] net: Remove unnecessary net action assertion
@ 2010-06-04 12:06 jamal
0 siblings, 0 replies; only message in thread
From: jamal @ 2010-06-04 12:06 UTC (permalink / raw)
To: davem; +Cc: Herbert Xu, Jiri Pirko, netdev
[-- Attachment #1: Type: text/plain, Size: 75 bytes --]
I will followup with another (independent) change on pedit.
cheers,
jamal
[-- Attachment #2: act-nomunge --]
[-- Type: text/plain, Size: 1141 bytes --]
commit 45c644796fe2aa834918b15d7b41e57ccf86c1b3
Author: Jamal Hadi Salim <hadi@cyberus.ca>
Date: Fri Jun 4 06:16:30 2010 -0400
net: Remove unnecessary net action assertion
The extra assertion to allow packet munging only when there are
no other ptypes listening which may have worked around an old bug
is unnecessary. It is sufficient to check if the skb is cloned before
trampling on it. Thanks to Herbert Xu for being persistent and patient
in getting this across.
[Note that cloning checks and assertions are the general rule used
by tc actions (documentation/networking/tc-actions-env-rules.txt)].
Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
diff --git a/net/core/dev.c b/net/core/dev.c
index ec01a59..b272752 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2662,9 +2662,6 @@ static inline struct sk_buff *handle_ing(struct sk_buff *skb,
if (*pt_prev) {
*ret = deliver_skb(skb, *pt_prev, orig_dev);
*pt_prev = NULL;
- } else {
- /* Huh? Why does turning on AF_PACKET affect this? */
- skb->tc_verd = SET_TC_OK2MUNGE(skb->tc_verd);
}
switch (ing_filter(skb)) {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-06-04 12:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-04 12:06 [PATCH net-next-2.6] net: Remove unnecessary net action assertion jamal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).