Re: [PATCH] net: check for refcount if pop a stacked dst_entry

Steffen Klassert
2010-06-04T11:24:20Z

On Fri, Jun 04, 2010 at 12:51:19PM +0200, Eric Dumazet wrote:
>
> Hmm, this might fix the thing, but we probably can do it without the
> dst_clone(), if you replace the
>
> skb_dst_set(skb, dst);
>
> by
>
> skb_dst_set_noref(skb, dst);
>
> in xfrm_output_one() ?
>

Yes, this should work too. I'll update the patch to use
skb_dst_set_noref() in xfrm_output_one() and remove the
dst_clone() in skb_dst_pop().