From: jamal <hadi@cyberus.ca>
To: Changli Gao <xiaosuo@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH v2] act_mirred: don't clone skb when skb isn't shared
Date: Sat, 05 Jun 2010 10:49:05 -0400 [thread overview]
Message-ID: <1275749345.3490.88.camel@bigi> (raw)
In-Reply-To: <1275741553-21463-1-git-send-email-xiaosuo@gmail.com>
On Sat, 2010-06-05 at 20:39 +0800, Changli Gao wrote:
> + if ((action == TC_ACT_SHOT || action == TC_ACT_STOLEN ||
I am not so sure about SHOT; the other two are fine.
> - skb2 = skb_act_clone(skb, GFP_ATOMIC);
> + at = G_TC_AT(skb->tc_verd);
Was there any need to move above line?
> + skb2 = skb_act_clone(skb, GFP_ATOMIC, m->tcf_action);
> - skb2->dev = dev;
Or this one?
> skb2->skb_iif = skb->dev->ifindex;
> + skb2->dev = dev;
cheers,
jamal
next prev parent reply other threads:[~2010-06-05 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 12:39 [PATCH v2] act_mirred: don't clone skb when skb isn't shared Changli Gao
2010-06-05 14:49 ` jamal [this message]
2010-06-05 14:58 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275749345.3490.88.camel@bigi \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox