From: Eric Dumazet <eric.dumazet@gmail.com>
To: xiaohui.xin@intel.com
Cc: netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mst@redhat.com, mingo@elte.hu,
davem@davemloft.net, herbert@gondor.apana.org.au,
jdike@linux.intel.com
Subject: Re: [RFC PATCH v7 08/19] Make __alloc_skb() to get external buffer.
Date: Sat, 05 Jun 2010 16:53:24 +0200 [thread overview]
Message-ID: <1275749604.5238.239.camel@edumazet-laptop> (raw)
In-Reply-To: <1275732899-5423-8-git-send-email-xiaohui.xin@intel.com>
Le samedi 05 juin 2010 à 18:14 +0800, xiaohui.xin@intel.com a écrit :
> From: Xin Xiaohui <xiaohui.xin@intel.com>
> child->fclone = SKB_FCLONE_UNAVAILABLE;
> }
> + /* Record the external buffer info in this field. It's not so good,
> + * but we cannot find another place easily.
> + */
> + shinfo->destructor_arg = ext_page;
> +
Yes this is a big problem, its basically using a cache line that was not
touched before.
next prev parent reply other threads:[~2010-06-05 14:53 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 10:14 [RFC PATCH v7 01/19] Add a new structure for skb buffer from external xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 02/19] Add a new struct for device to manipulate external buffer xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 03/19] Export 2 func for device to assign/deassign new strucure xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 04/19] Add a ndo_mp_port_prep pointer to net_device_ops xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 05/19] Add a function make external buffer owner to query capability xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 06/19] Add a function to indicate if device use external buffer xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 07/19] Add interface to get external buffers xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 08/19] Make __alloc_skb() to get external buffer xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 09/19] Ignore room skb_reserve() when device is using " xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 10/19] Don't do skb recycle, if device use " xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 11/19] Use callback to deal with skb_release_data() specially xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 12/19] Add a hook to intercept external buffers from NIC driver xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 13/19] To skip GRO if buffer is external currently xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 14/19] Add header file for mp device xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 15/19] Add basic funcs and ioctl to " xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 16/19] Manipulate external buffers in " xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 17/19] Export proto_ops to vhost-net driver xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 18/19] Add a kconfig entry and make entry for mp device xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 19/19] Provides multiple submits and asynchronous notifications xiaohui.xin
2010-06-05 10:14 ` [RFC PATCH v7 00/19] Provide a zero-copy method on KVM virtio-net xiaohui.xin
2010-06-05 14:56 ` [RFC PATCH v7 11/19] Use callback to deal with skb_release_data() specially Eric Dumazet
2010-06-09 7:30 ` Xin, Xiaohui
2010-06-05 14:53 ` Eric Dumazet [this message]
2010-06-09 7:34 ` [RFC PATCH v7 08/19] Make __alloc_skb() to get external buffer Xin, Xiaohui
2010-06-05 14:51 ` [RFC PATCH v7 03/19] Export 2 func for device to assign/deassign new strucure Eric Dumazet
2010-06-06 23:13 ` [RFC PATCH v7 01/19] Add a new structure for skb buffer from external Stephen Hemminger
2010-06-07 7:51 ` Andi Kleen
2010-06-07 8:17 ` Mitchell Erblich
2010-06-09 9:22 ` Xin, Xiaohui
2010-06-09 8:48 ` Xin, Xiaohui
2010-06-08 5:27 ` Herbert Xu
2010-06-09 9:54 ` Xin, Xiaohui
2010-06-11 5:21 ` Herbert Xu
2010-06-12 9:31 ` Xin, Xiaohui
2010-06-13 8:58 ` Xin, Xiaohui
2010-06-17 11:21 ` Herbert Xu
2010-06-18 5:26 ` Xin, Xiaohui
2010-06-18 5:59 ` Herbert Xu
2010-06-18 7:14 ` Xin, Xiaohui
2010-06-18 7:45 ` Herbert Xu
2010-06-20 10:06 ` Michael S. Tsirkin
2010-06-20 10:32 ` Herbert Xu
2010-06-20 10:39 ` Michael S. Tsirkin
2010-06-20 11:02 ` Herbert Xu
2010-06-20 11:11 ` Michael S. Tsirkin
2010-06-20 11:36 ` Herbert Xu
2010-06-20 11:47 ` Michael S. Tsirkin
2010-06-20 11:59 ` Herbert Xu
2010-06-20 12:48 ` Michael S. Tsirkin
2010-06-20 15:19 ` Ben Hutchings
2010-06-23 8:09 ` Dong, Eddie
2010-06-23 9:52 ` Herbert Xu
2010-06-23 10:05 ` Dong, Eddie
2010-06-24 10:08 ` Herbert Xu
2010-06-25 1:03 ` Dong, Eddie
2010-06-25 11:06 ` Michael S. Tsirkin
2010-06-27 6:14 ` Herbert Xu
2010-06-28 9:56 ` Xin, Xiaohui
2010-06-28 10:00 ` Michael S. Tsirkin
2010-07-03 9:12 ` Herbert Xu
2010-06-25 2:07 ` Xin, Xiaohui
2010-06-17 11:20 ` Herbert Xu
2010-06-09 8:29 ` Xin, Xiaohui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275749604.5238.239.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jdike@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=xiaohui.xin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox