From: Eric Dumazet <eric.dumazet@gmail.com>
To: Sonic Zhang <sonic.adi@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
uclinux-dist-devel <uclinux-dist-devel@blackfin.uclinux.org>
Subject: Re: [PATCH v2] netdev:bfin_mac: reclaim and free tx skb as soon as possible after transfer
Date: Mon, 07 Jun 2010 11:58:00 +0200 [thread overview]
Message-ID: <1275904680.2545.44.camel@edumazet-laptop> (raw)
In-Reply-To: <AANLkTimO47rtvIwYAwpaMYtK5SEnhM0m3AxL5q-8lvA7@mail.gmail.com>
Le vendredi 04 juin 2010 à 12:44 +0800, Sonic Zhang a écrit :
>
> Yes, you are right. dev_kfree_skb_irq() queues used skb to the
> complete queue. But, it is actually freed in the other soft irq
> NET_TX_SOFTIRQ.
I guess you didnt understood my mail, so I'll re-explain :
dev_kfree_skb_irq() queues skb only if packet is not already orphaned.
As most packets are now orphaned (in recent kernels where your patch
applies), dev_kfree_skb_irq() can free packet immediately, with no
NET_TX_SOFTIRQ overhead.
next prev parent reply other threads:[~2010-06-07 9:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 3:48 [PATCH v2] netdev:bfin_mac: reclaim and free tx skb as soon as possible after transfer sonic zhang
2010-06-03 4:05 ` Eric Dumazet
2010-06-03 8:57 ` Junchang Wang
2010-06-03 9:19 ` Eric Dumazet
2010-06-03 10:54 ` Junchang Wang
2010-06-04 3:29 ` Sonic Zhang
2010-06-04 4:05 ` Eric Dumazet
2010-06-04 4:44 ` Sonic Zhang
2010-06-07 9:58 ` Eric Dumazet [this message]
2010-06-07 10:26 ` Sonic Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275904680.2545.44.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sonic.adi@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox