From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Rémi Denis-Courmont" <remi@remlab.net>
Cc: Jiri Pirko <jpirko@redhat.com>,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next-2.6] phonet: use call_rcu for phonet device free
Date: Mon, 07 Jun 2010 15:49:43 +0200 [thread overview]
Message-ID: <1275918583.2545.84.camel@edumazet-laptop> (raw)
In-Reply-To: <474f08fed4a406e929af3d4142d3e185@chewa.net>
Le lundi 07 juin 2010 à 15:43 +0200, Rémi Denis-Courmont a écrit :
> On Mon, 7 Jun 2010 15:27:39 +0200, Jiri Pirko <jpirko@redhat.com> wrote:
> > Use call_rcu rather than synchronize_rcu.
> >
> > Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>
> This looks fine to me, but what is the goal here? The RCU documentation
> seems to imply that synchronize_rcu() is preferable over call_rcu() when at
> all possible.
>
Thats not exactly that.
synchronize_rcu() is easier, in respect of memory use.
But its drawback is current thread is blocked for several milli seconds.
In the end, call_rcu() is more scalable.
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
next prev parent reply other threads:[~2010-06-07 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 13:27 [PATCH net-next-2.6] phonet: use call_rcu for phonet device free Jiri Pirko
2010-06-07 13:43 ` Rémi Denis-Courmont
2010-06-07 13:49 ` Eric Dumazet [this message]
2010-06-09 23:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275918583.2545.84.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=remi@remlab.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox