From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection! Date: Wed, 09 Jun 2010 20:15:11 +0200 Message-ID: <1276107311.1745.66.camel@laptop> References: <20100608001929.GF2387@linux.vnet.ibm.com> <1275986441.5408.111.camel@twins> <1276004075.2987.208.camel@twins> <1276097068.1745.13.camel@laptop> <1276106229.1745.65.camel@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Cc: paulmck@linux.vnet.ibm.com, Vivek Goyal , Eric Paris , Lai Jiangshan , Ingo Molnar , LKML , nauman@google.com, eric.dumazet@gmail.com, netdev@vger.kernel.org, Jens Axboe , Gui Jianfeng , Li Zefan , Johannes Berg To: Miles Lane Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:41268 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754991Ab0FISPo convert rfc822-to-8bit (ORCPT ); Wed, 9 Jun 2010 14:15:44 -0400 In-Reply-To: <1276106229.1745.65.camel@laptop> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2010-06-09 at 19:57 +0200, Peter Zijlstra wrote: > + /* > + * We're not in the pid-hash yet so no cgroup attach races, and the > + * cgroup is pinned by the parent running this. > + * > + * Silence PROVE_RCU. > + */ Hum,.. not sure that's actually true though, the parent itself is still susceptible to races afaict..