* [PATCH] netem: fix installs of dist files
@ 2010-06-10 0:52 Mike Frysinger
2010-08-01 2:33 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2010-06-10 0:52 UTC (permalink / raw)
To: stephen.hemminger, netdev
The tc program searches LIBDIR by default for the .dist files, and that
defaults to /usr/lib. But the netem subdir has /lib/ hardcoded which
means the default build+install results in the files not being found.
Further, these are plain text files which are read at runtime, so it
doesn't make sense to give them executable bits.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
netem/Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/netem/Makefile b/netem/Makefile
index b6ccfc6..e52e125 100644
--- a/netem/Makefile
+++ b/netem/Makefile
@@ -20,9 +20,9 @@ stats: stats.c
$(HOSTCC) $(CCOPTS) -I../include -o $@ $@.c -lm
install: all
- mkdir -p $(DESTDIR)/lib/tc
+ mkdir -p $(DESTDIR)$(LIBDIR)/tc
for i in $(DISTDATA); \
- do install -m 755 $$i $(DESTDIR)/lib/tc; \
+ do install -m 644 $$i $(DESTDIR)$(LIBDIR)/tc; \
done
clean:
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netem: fix installs of dist files
2010-06-10 0:52 [PATCH] netem: fix installs of dist files Mike Frysinger
@ 2010-08-01 2:33 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2010-08-01 2:33 UTC (permalink / raw)
To: Mike Frysinger; +Cc: stephen.hemminger, netdev
On Wed, 9 Jun 2010 20:52:09 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> The tc program searches LIBDIR by default for the .dist files, and that
> defaults to /usr/lib. But the netem subdir has /lib/ hardcoded which
> means the default build+install results in the files not being found.
>
> Further, these are plain text files which are read at runtime, so it
> doesn't make sense to give them executable bits.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> netem/Makefile | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/netem/Makefile b/netem/Makefile
> index b6ccfc6..e52e125 100644
> --- a/netem/Makefile
> +++ b/netem/Makefile
> @@ -20,9 +20,9 @@ stats: stats.c
> $(HOSTCC) $(CCOPTS) -I../include -o $@ $@.c -lm
>
> install: all
> - mkdir -p $(DESTDIR)/lib/tc
> + mkdir -p $(DESTDIR)$(LIBDIR)/tc
> for i in $(DISTDATA); \
> - do install -m 755 $$i $(DESTDIR)/lib/tc; \
> + do install -m 644 $$i $(DESTDIR)$(LIBDIR)/tc; \
> done
>
> clean:
Applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-01 2:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-10 0:52 [PATCH] netem: fix installs of dist files Mike Frysinger
2010-08-01 2:33 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).