netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Fw: [Bug 16183] New: sch_teql no longer works post 2.6.30
@ 2010-06-11 16:08 Stephen Hemminger
  2010-06-11 17:43 ` Eric Dumazet
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2010-06-11 16:08 UTC (permalink / raw)
  To: Eric Dumazet, David Miller; +Cc: netdev



Begin forwarded message:

Date: Fri, 11 Jun 2010 15:56:44 GMT
From: bugzilla-daemon@bugzilla.kernel.org
To: shemminger@linux-foundation.org
Subject: [Bug 16183] New: sch_teql no longer works post 2.6.30


https://bugzilla.kernel.org/show_bug.cgi?id=16183

           Summary: sch_teql no longer works post 2.6.30
           Product: Networking
           Version: 2.5
    Kernel Version: 2.6.31 through 2.6.34
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: IPV4
        AssignedTo: shemminger@linux-foundation.org
        ReportedBy: tom@compton.nu
        Regression: Yes


Created an attachment (id=26729)
 --> (https://bugzilla.kernel.org/attachment.cgi?id=26729)
Patch to fix sch_teql

The sch_teql module, which can be used to load balance over a set of underlying
interfaces, stopped working after 2.6.30 and has been broken in all kernels
since then.

The problem is that the transmit routine relies on being able to access the
destination address in the skb in order to do ARP resolution once it has
decided which underlying interface it is going to transmit through.

In 2.6.31 the IFF_XMIT_DST_RELEASE flag was introduced, and set by default for
all interfaces, which causes the destination address to be release before the
transmit routine for the interface is called.

The solution (implemented in the attached patch) is to clear that flag for teql
interfaces.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


-- 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Fw: [Bug 16183] New: sch_teql no longer works post 2.6.30
  2010-06-11 16:08 Fw: [Bug 16183] New: sch_teql no longer works post 2.6.30 Stephen Hemminger
@ 2010-06-11 17:43 ` Eric Dumazet
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2010-06-11 17:43 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: David Miller, netdev

Le vendredi 11 juin 2010 à 09:08 -0700, Stephen Hemminger a écrit :
> 
> Begin forwarded message:
> 
> Date: Fri, 11 Jun 2010 15:56:44 GMT
> From: bugzilla-daemon@bugzilla.kernel.org
> To: shemminger@linux-foundation.org
> Subject: [Bug 16183] New: sch_teql no longer works post 2.6.30
> 
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=16183
> 
>            Summary: sch_teql no longer works post 2.6.30
>            Product: Networking
>            Version: 2.5
>     Kernel Version: 2.6.31 through 2.6.34
>           Platform: All
>         OS/Version: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: IPV4
>         AssignedTo: shemminger@linux-foundation.org
>         ReportedBy: tom@compton.nu
>         Regression: Yes
> 
> 
> Created an attachment (id=26729)
>  --> (https://bugzilla.kernel.org/attachment.cgi?id=26729)
> Patch to fix sch_teql
> 
> The sch_teql module, which can be used to load balance over a set of underlying
> interfaces, stopped working after 2.6.30 and has been broken in all kernels
> since then.
> 
> The problem is that the transmit routine relies on being able to access the
> destination address in the skb in order to do ARP resolution once it has
> decided which underlying interface it is going to transmit through.
> 
> In 2.6.31 the IFF_XMIT_DST_RELEASE flag was introduced, and set by default for
> all interfaces, which causes the destination address to be release before the
> transmit routine for the interface is called.
> 
> The solution (implemented in the attached patch) is to clear that flag for teql
> interfaces.
> 
> -- 
> Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug.
> 
> 

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>

Please note my old email address no longer works ;)

Thanks



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-06-11 17:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-11 16:08 Fw: [Bug 16183] New: sch_teql no longer works post 2.6.30 Stephen Hemminger
2010-06-11 17:43 ` Eric Dumazet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).