From: Eric Dumazet <eric.dumazet@gmail.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
"Pekka Savola (ipv6)" <pekkas@netcore.fi>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] fragment: add fast path
Date: Mon, 14 Jun 2010 08:40:37 +0200 [thread overview]
Message-ID: <1276497637.2478.1.camel@edumazet-laptop> (raw)
In-Reply-To: <1276493743.2448.41.camel@edumazet-laptop>
> I am not sure why we need "struct inet_skb_parm h;" field in struct
> ipfrag_skb_cb...
>
> I probably need to wakeup this monday morning ?
>
> Untested patch follows, only compiled.
>
Oh well, I see light now I woke up ;)
> [PATCH] frags: Remove unecessary bits
>
> While trying to move 'offset' to the beginning of frag CB, I found
> inet_skb_parm field was unused.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
Wrong patch of course.
We need some comment or document better why its there..
prev parent reply other threads:[~2010-06-14 6:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 23:16 [PATCH] fragment: add fast path Changli Gao
2010-06-14 1:18 ` David Miller
2010-06-14 2:03 ` Changli Gao
2010-06-14 2:24 ` YOSHIFUJI Hideaki
2010-06-14 2:52 ` Changli Gao
2010-06-14 2:55 ` Changli Gao
2010-06-14 5:15 ` YOSHIFUJI Hideaki
2010-06-14 6:19 ` Mitchell Erblich
2010-06-14 5:35 ` Eric Dumazet
2010-06-14 5:59 ` Changli Gao
2010-06-14 7:04 ` Eric Dumazet
2010-06-14 10:15 ` Changli Gao
2010-06-14 6:40 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276497637.2478.1.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=xiaosuo@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox