From: Eric Dumazet <eric.dumazet@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Pedro Garcia <pedro.netdev@dondevamos.com>,
Patrick McHardy <kaber@trash.net>,
Ben Hutchings <bhutchings@solarflare.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet)
Date: Mon, 14 Jun 2010 22:03:09 +0200 [thread overview]
Message-ID: <1276545789.2444.33.camel@edumazet-laptop> (raw)
In-Reply-To: <1276544573.4897.6.camel@Joe-Laptop.home>
Le lundi 14 juin 2010 à 12:42 -0700, Joe Perches a écrit :
> On Mon, 2010-06-14 at 19:11 +0200, Patrick McHardy wrote:
> > Additionally:
> > - the pr_debug statements may be useful for debugging, but are
> > a bit excessive for the final version
>
> Patrick, what's wrong with pr_debug?
> Do you prefer pr_devel?
In the patch context, this pr_debug() is not necessary.
Just remove it, since its a normal situation, no need to log anything,
ever.
prev parent reply other threads:[~2010-06-14 20:03 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 19:20 [PATCH] vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet) Pedro Garcia
2010-06-13 21:56 ` Ben Hutchings
2010-06-14 16:49 ` Pedro Garcia
2010-06-14 17:02 ` Ben Hutchings
2010-06-14 17:11 ` Patrick McHardy
2010-06-14 19:12 ` Eric Dumazet
2010-06-16 8:49 ` Pedro Garcia
2010-06-16 9:08 ` Eric Dumazet
2010-06-16 11:42 ` Patrick McHardy
2010-06-16 13:28 ` Pedro Garcia
2010-06-16 14:24 ` Arnd Bergmann
2010-06-16 15:28 ` Patrick McHardy
2010-06-16 18:26 ` Arnd Bergmann
2010-06-16 18:58 ` Eric Dumazet
2010-06-17 8:56 ` Vladislav Zolotarov
2010-06-17 10:28 ` Eric Dumazet
2010-06-17 14:08 ` Vladislav Zolotarov
2010-06-16 14:24 ` Eric Dumazet
2010-06-27 23:21 ` Pedro Garcia
2010-06-30 20:16 ` David Miller
2010-07-01 18:47 ` Pedro Garcia
2010-07-01 20:19 ` Eric Dumazet
2010-07-18 16:43 ` Pedro Garcia
2010-07-18 22:39 ` David Miller
2010-07-19 13:24 ` [BUG net-next-2.6] vlan, bonding, bnx2 problems Eric Dumazet
2010-07-19 16:35 ` David Miller
2010-07-19 18:14 ` Michael Chan
2010-07-19 20:19 ` Jay Vosburgh
2010-07-20 22:58 ` Jay Vosburgh
2010-06-24 18:28 ` [PATCH] vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet) Pedro Garcia Pelaez
2010-07-08 12:54 ` Vladislav Zolotarov
2010-07-08 12:58 ` Vladislav Zolotarov
2010-07-08 13:51 ` Vladislav Zolotarov
2010-06-14 19:42 ` Joe Perches
2010-06-14 20:03 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276545789.2444.33.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=pedro.netdev@dondevamos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox