From: "Michael Chan" <mchan@broadcom.com>
To: linux-pci@vger.kernel.org, netdev@vger.kernel.org
Subject: suspend/resume not working in MSIX mode
Date: Mon, 14 Jun 2010 18:13:22 -0700 [thread overview]
Message-ID: <1276564403.19104.28.camel@HP1> (raw)
I'm debugging the bnx2 driver which doesn't work after suspend/resume if
it is running in MSI-X mode. The problem is that during suspend, the
MSI-X vectors are disabled by the following sequence on x86:
take_cpu_down() -> cpu_disable_common() -> fixup_irqs()
The MSI-X address/data used to disable the vectors are remembered in the
above sequence. During resume, these address/data are then programmed
back to the device during pci_restore_state(), causing all the vectors
to remain disabled.
Some drivers call free_irq() during suspend and request_irq() during
resume, and that should avoid the problem. bnx2 and some other drivers
do not do that. These drivers rely on pci_restore_state() to restore
the MSI-X vectors to the same working state before suspend.
What's the right way to fix this? Thanks.
next reply other threads:[~2010-06-15 1:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 1:13 Michael Chan [this message]
2010-06-17 19:16 ` [PATCH] PCI: MSI: Remove unsafe and unnecessary hardware access Ben Hutchings
2010-06-17 23:58 ` Michael Chan
2010-07-02 23:16 ` Jesse Barnes
2010-10-15 18:26 ` Emil S Tantilov
2010-10-15 20:06 ` Jesse Barnes
2010-10-20 19:05 ` Tantilov, Emil S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276564403.19104.28.camel@HP1 \
--to=mchan@broadcom.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).