Re: [PATCH v5] netfilter: Xtables: idletimer target implementation

[Luciano Coelho <luciano.coelho@nokia.com>]

On Tue, 2010-06-15 at 13:54 +0200, ext Patrick McHardy wrote:
> Two final comments:
> 
> Luciano Coelho wrote:
> > diff --git a/include/linux/netfilter/xt_IDLETIMER.h b/include/linux/netfilter/xt_IDLETIMER.h
> > new file mode 100644
> > index 0000000..3e1aa1b
> > --- /dev/null
> > +++ b/include/linux/netfilter/xt_IDLETIMER.h
> 
> This file needs to be added to Kbuild to make sure it gets installed
> during "make headers_install".

Yes, thanks for pointing out.  I'll add it.


> > +static void idletimer_tg_destroy(const struct xt_tgdtor_param *par)
> > +{
> > +	const struct idletimer_tg_info *info = par->targinfo;
> > +
> > +	pr_debug("destroy targinfo %s\n", info->label);
> > +
> > +	mutex_lock(&list_mutex);
> > +	if (!info->timer) {
> >   
> 
> This doesn't seem to be possible.

As usual, you're right.  I'll remove this useless check.

v6 coming soon!

-- 
Cheers,
Luca.