public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Patrick McHardy <kaber@trash.net>
Cc: "netfilter-devel@vger.kernel.org"
	<netfilter-devel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"jengelh@medozas.de" <jengelh@medozas.de>,
	Timo Teras <timo.teras@iki.fi>
Subject: Re: [PATCH v6] netfilter: Xtables: idletimer target implementation
Date: Tue, 15 Jun 2010 16:18:54 +0300	[thread overview]
Message-ID: <1276607934.1580.58.camel@powerslave> (raw)
In-Reply-To: <4C177A89.7060301@trash.net>

On Tue, 2010-06-15 at 15:05 +0200, ext Patrick McHardy wrote:
> Luciano Coelho wrote:
> > This patch implements an idletimer Xtables target that can be used to
> > identify when interfaces have been idle for a certain period of time.
> >
> > Timers are identified by labels and are created when a rule is set with a new
> > label.  The rules also take a timeout value (in seconds) as an option.  If
> > more than one rule uses the same timer label, the timer will be restarted
> > whenever any of the rules get a hit.
> >
> > One entry for each timer is created in sysfs.  This attribute contains the
> > timer remaining for the timer to expire.  The attributes are located under
> > the xt_idletimer class:
> >
> > /sys/class/xt_idletimer/timers/<label>
> >
> > When the timer expires, the target module sends a sysfs notification to the
> > userspace, which can then decide what to do (eg. disconnect to save power).
> >   
> 
> Applied with a minor compiler warning fix:
> 
>   CC [M]  net/netfilter/xt_IDLETIMER.o
> net/netfilter/xt_IDLETIMER.c:255: warning: initialization from 
> incompatible pointer type
> 
> The struct xt_tgchk_param argument to ->checkentry is const.

Oops, missed that one.  Thanks for fixing it.

And thanks a lot for bearing with a netfilter newbie, providing lots of
good comments and generally helping me with this component! I really
appreciate it.

-- 
Cheers,
Luca.


      reply	other threads:[~2010-06-15 13:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15 12:45 [PATCH v6] netfilter: Xtables: idletimer target implementation Luciano Coelho
2010-06-15 13:05 ` Patrick McHardy
2010-06-15 13:18   ` Luciano Coelho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276607934.1580.58.camel@powerslave \
    --to=luciano.coelho@nokia.com \
    --cc=jengelh@medozas.de \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=timo.teras@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox