From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
herbert@gondor.apana.org.au, shemminger@vyatta.com,
mst@redhat.com, frzhang@redhat.com, netdev@vger.kernel.org,
amwang@redhat.com, mpm@selenic.com
Subject: Re: [0/8] netpoll/bridge fixes
Date: Wed, 16 Jun 2010 05:03:20 +0200 [thread overview]
Message-ID: <1276657400.19249.53.camel@edumazet-laptop> (raw)
In-Reply-To: <1276657139.19249.50.camel@edumazet-laptop>
Le mercredi 16 juin 2010 à 04:59 +0200, Eric Dumazet a écrit :
> Le mardi 15 juin 2010 à 11:39 -0700, David Miller a écrit :
> > From: Herbert Xu <herbert@gondor.apana.org.au>
> > Date: Fri, 11 Jun 2010 12:11:42 +1000
> >
> > > On Fri, Jun 11, 2010 at 08:48:39AM +1000, Herbert Xu wrote:
> > >> On Thu, Jun 10, 2010 at 02:59:15PM -0700, Stephen Hemminger wrote:
> > >> >
> > >> > Okay, then add a comment where in_irq is used?
> > >>
> > >> Actually let me put it into a wrapper. I'll respin the patches.
> > >
> > > OK here is a repost. And this time it really is 8 patches :)
> > > I've tested it lightly.
> >
> > All applied to net-next-2.6, thanks Herbert.
>
For this second splat, I dont know yet how to fix it, its 5 in the
morning here, I need a sleep ;)
At this point, no rcu_lock is held.
I wonder how these patches were tested, Herbert ?
[ 74.431712]
[ 74.431713] ===================================================
[ 74.431717] [ INFO: suspicious rcu_dereference_check() usage. ]
[ 74.431719] ---------------------------------------------------
[ 74.431722] include/linux/netpoll.h:85 invoked rcu_dereference_check() without protection!
[ 74.431725]
[ 74.431726] other info that might help us debug this:
[ 74.431727]
[ 74.431730]
[ 74.431730] rcu_scheduler_active = 1, debug_locks = 1
[ 74.431733] no locks held by swapper/0.
[ 74.431735]
[ 74.431736] stack backtrace:
[ 74.431739] Pid: 0, comm: swapper Not tainted 2.6.35-rc1-00508-gdbe3a24-dirty #78
[ 74.431742] Call Trace:
[ 74.431748] [<c132cf0c>] ? printk+0xf/0x13
[ 74.431754] [<c1059ac6>] lockdep_rcu_dereference+0x74/0x7d
[ 74.431759] [<c1297628>] __napi_gro_receive+0x4d/0xf6
[ 74.431764] [<c12977a3>] napi_gro_receive+0x19/0x24
[ 74.431775] [<f805d83f>] bnx2x_rx_int+0x101b/0x124e [bnx2x]
[ 74.431781] [<c1050ffc>] ? async_thread+0x198/0x1de
[ 74.431787] [<c129580f>] ? net_tx_action+0x9a/0x12a
[ 74.431797] [<f805f267>] bnx2x_poll+0x5d/0x18b [bnx2x]
[ 74.431801] [<c1297360>] ? net_rx_action+0x1e4/0x21a
[ 74.431805] [<c105ccb2>] ? trace_hardirqs_on_caller+0xe2/0x11c
[ 74.431810] [<c1297218>] net_rx_action+0x9c/0x21a
[ 74.431814] [<c1039a21>] __do_softirq+0x126/0x277
[ 74.431819] [<c10398fb>] ? __do_softirq+0x0/0x277
[ 74.431821] <IRQ> [<c1039c0d>] ? irq_exit+0x38/0x74
[ 74.431828] [<c1003d1f>] ? do_IRQ+0x87/0x9b
[ 74.431833] [<c1002d2e>] ? common_interrupt+0x2e/0x34
[ 74.431838] [<c105007b>] ? sched_clock_local+0x3f/0x11f
[ 74.431843] [<c11ba45b>] ? acpi_idle_enter_bm+0x271/0x2a0
[ 74.431848] [<c12797bd>] ? cpuidle_idle_call+0x76/0x151
[ 74.431852] [<c1001565>] ? cpu_idle+0x49/0x76
[ 74.431857] [<c1319ece>] ? rest_init+0xd6/0xdb
[ 74.431861] [<c156579f>] ? start_kernel+0x31b/0x320
[ 74.431865] [<c15650c9>] ? i386_start_kernel+0xc9/0xd0
next prev parent reply other threads:[~2010-06-16 3:03 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 12:40 [0/8] netpoll/bridge fixes Herbert Xu
2010-06-10 12:42 ` [PATCH 1/7] netpoll: Set npinfo to NULL even with ndo_netpoll_cleanup Herbert Xu
2010-06-10 12:42 ` [PATCH 2/7] bridge: Remove redundant npinfo NULL setting Herbert Xu
2010-06-10 12:42 ` [PATCH 3/7] netpoll: Fix RCU usage Herbert Xu
2010-06-10 12:42 ` [PATCH 4/7] netpoll: Add locking for netpoll_setup/cleanup Herbert Xu
2010-06-10 12:42 ` [PATCH 5/7] netpoll: Add ndo_netpoll_setup Herbert Xu
2010-06-10 12:42 ` [PATCH 6/7] netpoll: Allow netpoll_setup/cleanup recursion Herbert Xu
2010-06-10 12:42 ` [PATCH 7/7] bridge: Fix netpoll support Herbert Xu
2010-06-10 14:49 ` [0/8] netpoll/bridge fixes Stephen Hemminger
2010-06-10 21:56 ` Herbert Xu
2010-06-10 21:59 ` Stephen Hemminger
2010-06-10 22:48 ` Herbert Xu
2010-06-11 2:11 ` Herbert Xu
2010-06-11 2:12 ` [PATCH 1/8] netpoll: Set npinfo to NULL even with ndo_netpoll_cleanup Herbert Xu
2010-06-11 2:12 ` [PATCH 2/8] bridge: Remove redundant npinfo NULL setting Herbert Xu
2010-06-11 2:12 ` [PATCH 3/8] netpoll: Fix RCU usage Herbert Xu
2010-06-11 23:10 ` Paul E. McKenney
2010-06-11 2:12 ` [PATCH 4/8] netpoll: Add locking for netpoll_setup/cleanup Herbert Xu
2010-06-11 2:12 ` [PATCH 5/8] netpoll: Add ndo_netpoll_setup Herbert Xu
2010-06-11 2:12 ` [PATCH 6/8] netpoll: Allow netpoll_setup/cleanup recursion Herbert Xu
2010-06-25 1:21 ` Andrew Morton
2010-06-25 3:01 ` Herbert Xu
2010-06-25 3:30 ` David Miller
2010-06-25 3:50 ` Andrew Morton
2010-06-25 4:27 ` David Miller
2010-06-25 4:42 ` Andrew Morton
2010-06-25 4:52 ` David Miller
2010-06-25 8:08 ` Peter Zijlstra
2010-06-25 8:42 ` Andrew Morton
2010-06-25 9:45 ` Peter Zijlstra
2010-06-25 8:46 ` Ingo Molnar
2010-06-25 10:08 ` Nick Piggin
2010-06-11 2:12 ` [PATCH 7/8] netpoll: Add netpoll_tx_running Herbert Xu
2010-06-11 2:12 ` [PATCH 8/8] bridge: Fix netpoll support Herbert Xu
2010-06-11 3:08 ` fired a bug report on bugzilla.redhat.com Qianfeng Zhang
2010-06-15 10:28 ` [PATCH 8/8] bridge: Fix netpoll support Cong Wang
2010-06-17 10:38 ` Herbert Xu
2010-06-17 10:57 ` Cong Wang
2010-06-17 10:55 ` Herbert Xu
2010-06-18 3:06 ` Cong Wang
2010-06-11 20:03 ` [0/8] netpoll/bridge fixes Matt Mackall
2010-06-15 10:17 ` Cong Wang
2010-06-15 18:39 ` David Miller
2010-06-16 2:58 ` Eric Dumazet
2010-06-16 3:03 ` Eric Dumazet [this message]
2010-06-16 3:33 ` Herbert Xu
2010-06-16 4:47 ` David Miller
2010-06-16 23:02 ` Paul E. McKenney
2010-06-17 10:18 ` Michael S. Tsirkin
2010-06-17 21:26 ` Paul E. McKenney
2010-06-16 6:16 ` Eric Dumazet
2010-06-16 5:08 ` Paul E. McKenney
2010-06-16 6:21 ` Eric Dumazet
2010-06-16 16:01 ` Paul E. McKenney
2010-07-19 10:19 ` Michael S. Tsirkin
2010-07-19 10:53 ` Herbert Xu
2010-07-19 11:54 ` Herbert Xu
2010-07-19 16:05 ` David Miller
2010-07-19 16:52 ` Eric Dumazet
2010-07-19 20:35 ` David Miller
2010-07-20 5:26 ` Herbert Xu
2010-07-20 6:28 ` David Miller
2010-06-29 12:53 ` Yanko Kaneti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276657400.19249.53.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=frzhang@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=mpm@selenic.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox