From: Filip Aben <f.aben@option.com>
To: davem@davemloft.net, gregkh@suse.de
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] hso: remove setting of low_latency flag
Date: Thu, 17 Jun 2010 11:03:35 +0200 [thread overview]
Message-ID: <1276765415.1532.5.camel@filip-linux> (raw)
In-Reply-To: <alpine.DEB.2.00.1006111100250.6812@filip-linux>
Hi all,
Did the patch below get accepted or is there a problem with it ?
Haven't seen it appearing in any git trees so far.
Thanks,
Filip-
On Fri, 2010-06-11 at 11:17 +0200, f.aben@option.com wrote:
> This patch removes the setting of the low_latency flag.
> tty_flip_buffer_push() is occasionally being called in irq context, which
> causes a hang if the low_latency flag is set.
> Removing the low_latency flag only seems to impact the flush to ldisc,
> which will now be put on a workqueue.
>
> Signed-off-by: Filip Aben <f.aben@option.com>
>
> ---
>
> diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
> index 0a3c41f..4dd2351 100644
> --- a/drivers/net/usb/hso.c
> +++ b/drivers/net/usb/hso.c
> @@ -1334,7 +1334,6 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp)
> /* check for port already opened, if not set the termios */
> serial->open_count++;
> if (serial->open_count == 1) {
> - tty->low_latency = 1;
> serial->rx_state = RX_IDLE;
> /* Force default termio settings */
> _hso_serial_set_termios(tty, NULL);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-06-17 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 9:17 [PATCH] hso: remove setting of low_latency flag f.aben
2010-06-17 9:03 ` Filip Aben [this message]
2010-06-22 17:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276765415.1532.5.camel@filip-linux \
--to=f.aben@option.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).