potential bug in bnep_net_set_mc_list()

Dan Carpenter
2010-06-18T23:09:17Z

This is from ff6e2163f28a: "net: convert multiple drivers to use
netdev_for_each_mc_addr, part7"

net/bluetooth/bnep/netdev.c
101 i = 0;
102 netdev_for_each_mc_addr(ha, dev) {
103 if (i == BNEP_MAX_MULTICAST_FILTERS)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

104 break;
105 memcpy(__skb_put(skb, ETH_ALEN), ha->addr, ETH_ALEN);
106 memcpy(__skb_put(skb, ETH_ALEN), ha->addr, ETH_ALEN);
107 }

"i" is never incremented here so the check is always false.

regards,
dan carpenter