From: Mathieu Lacage <mathieu.lacage@sophia.inria.fr>
To: Mitchell Erblich <erblichs@earthlink.net>
Cc: netdev@vger.kernel.org
Subject: Re: PATCH: uninitialized memory access in tcp_parse_options
Date: Mon, 21 Jun 2010 21:10:46 +0200 [thread overview]
Message-ID: <1277147446.9469.67.camel@localhost.localdomain> (raw)
In-Reply-To: <3E37AD8C-208F-42B8-AA04-E0B294D909A8@earthlink.net>
On Mon, 2010-06-21 at 11:02 -0700, Mitchell Erblich wrote:
> The standard default for TCP with IPv4 is 536, which
> translates to 576 MTU.
>
> Thus, why don't you init mss to 536?
I don't know: I am not a tcp expert and I am not sure I really
understand the way this function is expected to be used by callers but I
sent a patch to make sure that someone would feel compelled to find the
right fix. It looks like callers of this function are expected to
initialize the fields themselves so, the idea of doing the
initialization in tcp_parse_options is probably bad.
Mathieu
--
Mathieu Lacage <mathieu.lacage@sophia.inria.fr>
Tel: +33 4 9238 5056
next prev parent reply other threads:[~2010-06-21 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 13:34 PATCH: uninitialized memory access in tcp_parse_options Mathieu Lacage
2010-06-21 18:02 ` Mitchell Erblich
2010-06-21 19:10 ` Mathieu Lacage [this message]
2010-06-26 5:58 ` Eric Dumazet
2010-06-29 4:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277147446.9469.67.camel@localhost.localdomain \
--to=mathieu.lacage@sophia.inria.fr \
--cc=erblichs@earthlink.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).