From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [ethtool PATCH] ethtool: Support n-tuple filter programming Date: Tue, 22 Jun 2010 12:45:45 +0100 Message-ID: <1277207145.2091.3.camel@achroite.uk.solarflarecom.com> References: <20100204075101.16661.95658.stgit@localhost.localdomain> <1277150272.2100.47.camel@achroite.uk.solarflarecom.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "Kirsher, Jeffrey T" , "jeff@garzik.org" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "gospo@redhat.com" To: Peter P Waskiewicz Jr Return-path: Received: from mail.solarflare.com ([216.237.3.220]:30424 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754562Ab0FVLpt (ORCPT ); Tue, 22 Jun 2010 07:45:49 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2010-06-21 at 13:31 -0700, Peter P Waskiewicz Jr wrote: > On Mon, 21 Jun 2010, Ben Hutchings wrote: > > > On Wed, 2010-02-03 at 23:51 -0800, Jeff Kirsher wrote: > >> From: Peter Waskiewicz > >> > >> Program underlying ethernet devices with n-tuple flow classification > >> filters. > >> > >> This also adds a new flag to ethtool_flags, allowing n-tuple > >> programming to be toggled using the set_flags call. > > > > I just noticed a problem with the implementation which makes me wonder > > whether this was tested at all: > > Yes, it was tested. We didn't hit every corner case, which I think your > catch below is a corner case issue. Our hardware can only do so much. It's not a corner case. You have added options that cannot work correctly. [...] > When this was proposed, we added the IPv4 address as a single int. People > seemed ok with it at the time, so we went with it. If you have a > different approach, please present it. And you don't think it matters that the address has to be written differently on big- and little-endian architectures? Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.