From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH net-next-2.6 2/5] sfc: Implement message level control
Date: Thu, 24 Jun 2010 04:12:18 +0100 [thread overview]
Message-ID: <1277349138.26161.144.camel@localhost> (raw)
In-Reply-To: <20100623.182920.28799851.davem@davemloft.net>
On Wed, 2010-06-23 at 18:29 -0700, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Wed, 23 Jun 2010 22:30:07 +0100
>
> > @@ -850,6 +866,8 @@ const struct ethtool_ops efx_ethtool_ops = {
> > .get_drvinfo = efx_ethtool_get_drvinfo,
> > .get_regs_len = efx_ethtool_get_regs_len,
> > .get_regs = efx_ethtool_get_regs,
> > + .get_msglevel = efx_ethtool_get_msglevel,
> > + .set_msglevel = efx_ethtool_set_msglevel,
> > .nway_reset = efx_ethtool_nway_reset,
> > .get_link = efx_ethtool_get_link,
> > .get_eeprom_len = efx_ethtool_get_eeprom_len,
>
> davem@sunset:~/src/GIT/net-next-2.6$ egrep get_regs_len drivers/net/sfc/ethtool.c
> davem@sunset:~/src/GIT/net-next-2.6$
>
> I don't know what tree you're patching this against, but neither net-2.6 nor
> net-next-2.6 have the context you have here in your patch so these patches
> do not apply at all.
I'm hoping you're going to apply
<http://patchwork.ozlabs.org/patch/56308> first.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-06-24 3:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 21:27 [PATCH net-next-2.6 0/5] sfc changes for 2.6.36 Ben Hutchings
2010-06-23 21:29 ` [PATCH net-next-2.6 1/5] sfc: Log MTD errors using partition name, not just net device name Ben Hutchings
2010-06-23 21:30 ` [PATCH net-next-2.6 2/5] sfc: Implement message level control Ben Hutchings
2010-06-24 1:29 ` David Miller
2010-06-24 3:12 ` Ben Hutchings [this message]
2010-06-24 21:33 ` David Miller
2010-06-23 21:30 ` [PATCH net-next-2.6 3/5] sfc: Replace EFX_DRIVER_NAME with KBUILD_MODNAME Ben Hutchings
2010-06-23 21:30 ` [PATCH net-next-2.6 4/5] sfc: Disable setting feature flags that are not implemented Ben Hutchings
2010-06-23 21:31 ` [PATCH net-next-2.6 5/5] sfc: Record hardware RX hash on each skb where possible Ben Hutchings
2010-06-24 15:18 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277349138.26161.144.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).