From: Ben Hutchings <bhutchings@solarflare.com>
To: Jeff Garzik <jgarzik@redhat.com>
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: [PATCH ethtool 2/5] ethtool: Mark show_usage() as noreturn
Date: Fri, 25 Jun 2010 15:48:46 +0100 [thread overview]
Message-ID: <1277477326.2094.7.camel@achroite.uk.solarflarecom.com> (raw)
In-Reply-To: <1277477027.2094.2.camel@achroite.uk.solarflarecom.com>
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
This prevents the next patch from provoking an incorrect warning about
an uninitialised variable.
Ben.
ethtool.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/ethtool.c b/ethtool.c
index 8969390..d4bf5a8 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -220,6 +220,8 @@ static struct option {
};
+static void show_usage(int badarg) __attribute__((noreturn));
+
static void show_usage(int badarg)
{
int i;
--
1.6.2.5
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-06-25 14:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 14:43 [PATCH ethtool 0/5] Fix and enhance command-line parsing Ben Hutchings
2010-06-25 14:46 ` [PATCH ethtool 1/5] ethtool: Parse integers into variables of different sizes and byte orders Ben Hutchings
2010-06-25 14:48 ` Ben Hutchings [this message]
2010-06-25 14:49 ` [PATCH ethtool 3/5] ethtool: Add support for named flags Ben Hutchings
2010-06-25 14:49 ` [PATCH ethtool 4/5] ethtool: Implement named message type flags Ben Hutchings
2010-06-25 17:11 ` Jeff Garzik
2010-06-25 14:50 ` [PATCH ethtool 5/5] ethtool: Use named flag support to update extended offload flags Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277477326.2094.7.camel@achroite.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=jgarzik@redhat.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox