From: Ben Hutchings <bhutchings@solarflare.com>
To: "Choi, David" <David.Choi@Micrel.Com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH linux-2.6.35-rc3] micrel phy driver
Date: Mon, 28 Jun 2010 20:23:47 +0100 [thread overview]
Message-ID: <1277753027.2089.22.camel@achroite.uk.solarflarecom.com> (raw)
In-Reply-To: <C43529A246480145B0A6D0234BDB0F0D0212A2@MELANITE.micrel.com>
On Mon, 2010-06-28 at 11:51 -0700, Choi, David wrote:
[...]
> @@ -106,8 +233,12 @@ MODULE_LICENSE("GPL");
>
> static struct mdio_device_id micrel_tbl[] = {
> { PHY_ID_KSZ9021, 0x000fff10 },
> - { PHY_ID_VSC8201, 0x00fffff0 },
> { PHY_ID_KS8001, 0x00fffff0 },
> + { PHY_ID_KSZ9021, 0x000fff10 },
> + { PHY_ID_KS8001, 0x00fffff0 },
> + { PHY_ID_KS8737, 0x00fffff0 },
> + { PHY_ID_KS8041, 0x00fffff0 },
> + { PHY_ID_KS8051, 0x00fffff0 },
> { }
> };
You're duplicating the device IDs for KSZ9021 and KS8001.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2010-06-28 19:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 18:51 [PATCH linux-2.6.35-rc3] micrel phy driver Choi, David
2010-06-28 19:23 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277753027.2089.22.camel@achroite.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=David.Choi@Micrel.Com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox