From: jamal <hadi@cyberus.ca>
To: Andreas Steffen <andreas.steffen@strongswan.org>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH] xfrm: fix XFRMA_MARK extraction in xfrm_mark_get
Date: Wed, 30 Jun 2010 06:07:25 -0400 [thread overview]
Message-ID: <1277892445.3509.2.camel@bigi> (raw)
In-Reply-To: <4C2AF8EE.8030508@strongswan.org>
On Wed, 2010-06-30 at 09:57 +0200, Andreas Steffen wrote:
> Determine the size of the xfrm_mark struct, not of its pointer.
>
> Signed-off-by: Andreas Steffen <andreas.steffen@strongswan.org>
Good catch (you are right this was tested on 64 bit ;->).
The preferred style would be what Simon mentioned. No biggie if
you keep it this way - but if you resubmit, add:
Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
cheers,
jamal
next prev parent reply other threads:[~2010-06-30 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 7:57 [PATCH] xfrm: fix XFRMA_MARK extraction in xfrm_mark_get Andreas Steffen
2010-06-30 10:07 ` jamal [this message]
2010-06-30 17:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277892445.3509.2.camel@bigi \
--to=hadi@cyberus.ca \
--cc=andreas.steffen@strongswan.org \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).