From: Sathya Perla <sathyap@serverengines.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH] be2net: memory barrier fixes on IBM p7 platform
Date: Thu, 01 Jul 2010 11:53:55 +0530 [thread overview]
Message-ID: <1277965435.4345.0.camel@ubuntu.ubuntu-domain> (raw)
In-Reply-To: <20100630.132749.218066997.davem@davemloft.net>
On Wed, 2010-06-30 at 13:27 -0700, David Miller wrote:
> > -
> > +
> > + rmb();
>
> That first addition does nothing but add erroneous trailing
> whitespace.
>
> You can physically see that something must be wrong here just by look
> at this patch chunk, please review things more thoroughly before
> submitting in the future.
>
Will do, thanks.
___________________________________________________________________________________
This message, together with any attachment(s), contains confidential and proprietary information of
ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized
review, printing, retention, copying, disclosure or distribution is strictly prohibited. If you are not the
intended recipient of this message, please immediately advise the sender by reply email message and
delete all copies of this message and any attachment(s). Thank you.
prev parent reply other threads:[~2010-07-01 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 10:11 [net-next-2.6 PATCH] be2net: memory barrier fixes on IBM p7 platform Sathya Perla
2010-06-30 20:27 ` David Miller
2010-07-01 6:23 ` Sathya Perla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277965435.4345.0.camel@ubuntu.ubuntu-domain \
--to=sathyap@serverengines.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).